openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update openstack-ansible-os_cinder from branch 'master'
  to 7e2cf5283f9cfb3a8a02263a3c0b0bd4d0518a58
  - Restart cinder-purge-deleted service only on abnormal exit
    
    Default value of Restart for any service which type is not `oneshot` is
    `on-failure`. While this suits most usecases, this leads to unexpected
    consequences for cinder-purge-deleted.service.
    
    In case there're some historical inconsistencies in the database which
    make impossible to flush deleted volumes from the database
    (ie due to prior manual intervention), cinder-manage exists with code 1
    which triggers systemd to restart the service and attempt cleanup again.
    
    The troublesome part is the transactional behaviour of the script. With
    each run it locks records in it's transaction that is failing and being
    reverted in a loops with 2 sec delay, that not only causes unnecessary
    load for database itself, but also causes deadlocks during operations
    with volumes that are not being re-tryed and fail with 500 return code
    in cinder-api.
    
    Changing Restart to `on-abnormal` will leave service in a failed state
    and systemd won't attempt to restart it.
    
    Change-Id: Ib091cc11a16fcd31ef351d9ec21d070d25829791
This commit is contained in:
Dmitriy Rabotyagov 2023-12-15 14:55:05 +01:00 committed by Gerrit Code Review
parent 1fc8e84d1c
commit f58493f613
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack-ansible-os_cinder

@ -1 +1 @@
Subproject commit b9b06052cba70b65d797112c441d244f7efa48aa
Subproject commit 7e2cf5283f9cfb3a8a02263a3c0b0bd4d0518a58