zuul
/
nodepool
Code Issues Proposed changes

Cleanup test_over_quota 

The test_over_quota has some debug lines that should be removed. Also
make the copy of the nodeset more intuitive.

Change-Id: I9a168bc1446e3bb479cace68ed932401ebcdd2bf
This commit is contained in:
Tobias Henkel 2018-07-06 19:34:58 +02:00
parent 31c276c234
commit ce9120192b
No known key found for this signature in database
GPG Key ID: 03750DEC158E5FA2
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nodepool/driver/__init__.py
View File

@ -655,7 +655,7 @@ class NodeRequestHandler(NodeRequestHandlerNotifications,
# Launches are complete, so populate ready_nodes and failed_nodes.
aborted_nodes = []
for node in self.nodeset[:]:
for node in self.nodeset.copy():
if node.state == zk.READY:
self.ready_nodes.append(node)
elif node.state == zk.ABORTED:

2
nodepool/tests/test_launcher.py
View File

@ -306,9 +306,7 @@ class TestLauncher(tests.DBTestCase):
pool_worker = pool.getPoolWorkers('fake-provider')
while not pool_worker[0].paused_handler:
# self.log.debug("tick")
time.sleep(0.1)
self.log.debug("finished waiting")
# The handler is paused now and the request should be in state PENDING
req2 = self.waitForNodeRequest(req2, zk.PENDING)