In the Zuul project in general we try to avoid having nitpicky
arguments about code style. Unless it causes a real problem,
we usually accept the stylistic aspects of code as people write
it. Since js indentation is not functional, like python, let's
ignore it.
Change-Id: If787e9a9fee92bdca1c4add448a5c85f02d4118d
Previously indentation was not checked at all and in order to avoid
reviewers time with style checks, we can enforce it with eslint.
Current js/jsx changes were made by: yarn lint-fix
Note this this change can easily become outdated so we need to
coordinate and merge it quickly as each rebase would loose previous
votes.
Change-Id: I85883fc8db924ad4ce9acad5acdd42aed7e4d0e4
This enables the redux developer tools for the browser. To make use of
this, one must also install the Redux DevTools extension which is
available for various browsers. The extension visualize all state
transitions in the redux store and also allows changing them manually to
see the effects.
Additionally, this change makes use of the third-party library called
"redux-immutable-state-invariant", which throws exception in development
mode whenever a state is mutated directly within an action or reducer.
Change-Id: I8a8588cd7f5f1b17b247d9700a492e5c1e27f040
While trying to figure out why the ansi patch wouldn't
build it emerged that we're now 2 major releases behind
on create-react-app.
Update create-react-app to the latest 3.4.1. This also updates
react to 16.13, and updates eslint globals processing so that
we don't have to declare globals in headers when we've
declared them already in the eslint file.
Finally, although this doesn't do it, create-react-app 3
has support for typescript, so if we want we can start migrating
files to .ts or .tsx extensions and start doing typing in
them.
Pin nanoid to v2 until such a time as create-react-app can be
updated to 3.4.2 which is needed ot handle .cjs extensions
being used by nanoid.
Change-Id: Ibc69bef605a62e4fdd2ebba33d9d1b822e7dfeba
var in javascript has some surprising behaviors, especially for those
of us from a python background, and can hide some errors. There's a
good article on it here: https://tylermcginnis.com/var-let-const/
Tell eslint to not allow the use of var and instead require either
let or const. Then update the one use.
Change-Id: Idd4b0a9086a68070dc35b546b7f73701c94ba1b0
This looks for a zuul_manifest artifact, and if it is present,
it fetches it and shows a tree view of logs. Text logs are
displayed in-app with some basic line anchoring.
Part of the implementation of
https://zuul-ci.org/docs/zuul/developer/specs/logs.html
es6 added to .eslint to allow use of Promise.
Change-Id: Ib04d013b4118005ba66a91d2bec0b0c429d12863
Axios <= 0.18.0 should apparently not be used any longer. Bump this to
0.19.0 and regenerate the yarn lock. This does update all the other
packages too because that is how yarn.lock works.
Note we have to fix the linter errors in the process (and clear out an
annoying warning).
Change-Id: Iabf5171ce8e0ccfabbebc7784da3299b2fd04693
- react-scripts>2.0.0 supports requirements written in newer javascript.
- eslint=5.6.0 is required by react-scripts>2.0.0
- update redux, patternfly-react and react to latest release
- default browserslist is added to the packages.json
- fix new eslint error
Change-Id: Ibee14604b364ce8d4133bcc409a70402bdde9df0
Revert "Fix publish-openstack-javascript-content"
This reverts commit ca199eb9db.
This reverts commit 1082faae95.
This appears to remove the tarball publishing system that we rely on.
Change-Id: Id746fb826dfc01b157c5b772adc1d2991ddcd93a