summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
22 hoursMerge "Modify some file content errors"HEADmasterZuul
24 hoursMerge "Use combined status for Github status checks"Zuul
7 daysMerge "Add spacing to Queue lengths line"Zuul
7 daysModify some file content errorsgaobin
The following error exectuor to executor formated to formatted overidden to overridden Change-Id: Ie80e1632624c65adaf6aad86a2c7aae93da688ff Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 17 Dec 2018 20:00:11 +0000 Reviewed-on: https://review.openstack.org/624278 Project: openstack-infra/zuul Branch: refs/heads/master
8 daysAdd spacing to Queue lengths lineJonathan Herlin
Add some spaces to the comma separated line in Zuul status page. Change-Id: I847ed57fbd95da0618029facbb84d81ea4a411ff Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Workflow+1: Joshua Hesketh <josh@nitrotech.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 11 Dec 2018 07:37:41 +0000 Reviewed-on: https://review.openstack.org/623960 Project: openstack-infra/zuul Branch: refs/heads/master
8 daysMerge "Fixed the word from congfiguration to configuration"Zuul
8 daysMerge "Fixed the necesssary to necessary"Zuul
9 daysMerge "Add a statsd check for clashing keys"Zuul
9 daysMerge "Rework zuul nodepool stats reporting"Zuul
9 daysAdd a statsd check for clashing keysIan Wienand
This added unit-test check ensures that when we assert a statsd key is set, we haven't tried to set any other subkeys under existing counter or gauge keys. Although this is not 100% reliable as different tests could still create conflicting keys, this would have at least found the problems in I127e8b6d08ab86e0f24018fd4b33c626682c76c7 and thus rules out one sort of problem. Fix the existing statsd test-case which is trying to set subkeys that wouldn't work; rename them as we're we're testing the hostname expansion. Also add a negative test to ensure the failure is found when asserting. Change-Id: Ie1ca39659d32e45e0ad1d80ca55e28ae6568a8b4 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 10 Dec 2018 04:42:45 +0000 Reviewed-on: https://review.openstack.org/620436 Project: openstack-infra/zuul Branch: refs/heads/master
9 daysRework zuul nodepool stats reportingIan Wienand
The current stats set a counter zuul.nodepool.<status> but then tries to set more counters like zuul.nodepool.<status>.label. This doesn't work because zuul.nodepool.<status> is already a counter value; it can't also be an intermediate key. Note this *does* work with the timer values, but that's because statsd is turning the timer into individual values (e.g. zuul.nodepool.<status>.<mean|count|std...>) as it flushes each interval. Thus we need to rethink these stats. This puts them under a new intermeidate key "requests" and adds a "total" count; thus zuul.nodepool.<status> == zuul.nodepool.requests.<status>.total The other stats, showing requests by-label and by-size will now live under the zuul.nodepool.requests parent. While we're here, use a statsd pipeline to send the status update as it works better when sending lots of stats quickly over UDP. This isn't handled by the current debug log below; move this into the test-case framework. The documentation has been clarified to match the code. Change-Id: I127e8b6d08ab86e0f24018fd4b33c626682c76c7 Notes (review): Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 10 Dec 2018 04:42:44 +0000 Reviewed-on: https://review.openstack.org/620285 Project: openstack-infra/zuul Branch: refs/heads/master
10 daysFixed the necesssary to necessarygaobin
Change-Id: Ic96a00618e1c98ee1b0339d360351be719aa676d Notes (review): Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Workflow+1: Joshua Hesketh <josh@nitrotech.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 10 Dec 2018 14:37:41 +0000 Reviewed-on: https://review.openstack.org/623646 Project: openstack-infra/zuul Branch: refs/heads/master
10 daysFixed the word from congfiguration to configurationgaobin
Change-Id: Ief2c7f7db59c32f412a331dea430272ae1b63341 Notes (review): Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Workflow+1: Joshua Hesketh <josh@nitrotech.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 10 Dec 2018 14:40:22 +0000 Reviewed-on: https://review.openstack.org/623634 Project: openstack-infra/zuul Branch: refs/heads/master
11 daysConsider shared changes queues for relative_priorityJames E. Blair
When calculating relative_priority for independent pipelines, use shared change queues just as is done for dependent pipelines. To implement this, we now calculate shared change queues for all pipelines, not just dependent ones, though we don't use those queues for any purpose other than this. Change-Id: I59b1090ca1f4fcc72276445e6ff4c5cf4f2f5030 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 08 Dec 2018 12:11:45 +0000 Reviewed-on: https://review.openstack.org/623595 Project: openstack-infra/zuul Branch: refs/heads/master
11 daysCap mypyJames E. Blair
The 0.650 release appears to dislike our use of pyyaml. Change-Id: I4ac0029b9b84d523ad5a09293886d3b7a83a3175 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 08 Dec 2018 02:13:11 +0000 Reviewed-on: https://review.openstack.org/623598 Project: openstack-infra/zuul Branch: refs/heads/master
11 daysMerge "Add nodepool.host_id variable to inventory file"Zuul
11 daysMerge "web: refactor tenants page to use a reducer"Zuul
11 daysMerge "web: refactor job page to use a reducer"Zuul
11 daysMerge "Add default value for relative_priority"Zuul
11 daysAdd nodepool.host_id variable to inventory filePaul Belanger
We recently exposed node.host_id in zookeeper from nodepool. Also include it into the inventory file so jobs can access it. Change-Id: Ic90af15dd86555aca2ce09120715b0aeb8af8516 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 07 Dec 2018 18:21:12 +0000 Reviewed-on: https://review.openstack.org/623496 Project: openstack-infra/zuul Branch: refs/heads/master
11 daysUse combined status for Github status checksTobias Henkel
When checking the required status checks we currently get all statuses and get the successful of them. However Github returns all historic status changes there. So a change that get a successful check, then a recheck and then a failed check still enters the gate but will be prohibited by Github to merge in the end. However github also offers us a combined status call that only returns the current state of the statuses. Using this fixes the issue. Change-Id: Iec3b2a3dfc8626870381604badd40de71e7257b9 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 17 Dec 2018 17:21:26 +0000 Reviewed-on: https://review.openstack.org/623417 Project: openstack-infra/zuul Branch: refs/heads/master
11 daysMerge "web: refactor jobs page to use a reducer"Zuul
11 daysMerge "web: refactor status page to use a reducer"Zuul
11 daysAdd default value for relative_priorityQuique Llorente
If we don't do so we get this error reading from model when there is no relative_priority attribute at zuul.conf File "/usr/local/lib/python3.7/site-packages/zuul/model.py", line 752, in updateFromDict self.relative_priority = data['relative_priority'] KeyError: 'relative_priority' Change-Id: I68e958b87072bed671c9b1efd2e9e3a20f700ec4 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 07 Dec 2018 16:25:01 +0000 Reviewed-on: https://review.openstack.org/622175 Project: openstack-infra/zuul Branch: refs/heads/master
12 daysMerge "Read old json data right before writing new data"Zuul
12 daysRead old json data right before writing new dataMonty Taylor
Instead of holding the old log data in RAM for the entire run, just read it in right before writing the new data out. Change-Id: I9785475b8c876f2cf8e61c5926e6c9d43a432deb Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 06 Dec 2018 21:55:58 +0000 Reviewed-on: https://review.openstack.org/623245 Project: openstack-infra/zuul Branch: refs/heads/master
12 daysMerge "web: add error reducer and info toast notification"Zuul
12 daysMerge "web: refactor info and tenant reducers action"Zuul
12 daysMerge "web: break the reducers module into logical units"Zuul
12 daysweb: refactor tenants page to use a reducerTristan Cacqueray
This change updates the tenants page component to dispatch reducer action instead of direct axios call. This enables using the generic error reducers as well as keeping the tenants list in the store to avoid repeated query. Change-Id: Ie1e16ce417f4ba6785b2f9efceddd2004e2203b0 Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 07 Dec 2018 16:35:35 +0000 Reviewed-on: https://review.openstack.org/623157 Project: openstack-infra/zuul Branch: refs/heads/master
12 daysweb: refactor job page to use a reducerTristan Cacqueray
This change updates the job page component to dispatch reducer action instead of direct axios call. This enables using the generic error reducers as well as keeping the tenant jobs in the store to avoid repeated query. Change-Id: I142493c3a89379a75d97d247fbe1fcc0858e9723 Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 07 Dec 2018 16:32:41 +0000 Reviewed-on: https://review.openstack.org/623156 Project: openstack-infra/zuul Branch: refs/heads/master
12 daysweb: refactor jobs page to use a reducerTristan Cacqueray
This change updates the jobs page component to dispatch reducer action instead of direct axios call. This enables using the generic error reducers as well as keeping the jobs list in the store to avoid repeated query. This change also refactor the Job list into a container and extends the common refresh component. Change-Id: I7f44e83d6bea8ee915c81d7ba9afd6d9a4c89d38 Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 07 Dec 2018 07:06:12 +0000 Reviewed-on: https://review.openstack.org/621396 Project: openstack-infra/zuul Branch: refs/heads/master
13 daysAdd instructions for reporting vulnerabilitiesJeremy Stanley
Prominently in the Zuul User Guide, include a brief overview of preferred methods for reporting suspected security vulnerabilities. Also link to it from the README in such a way that the same reference can be reused in other related Zuul repositories following the same policy. Change-Id: I2bd13bd13372f26c328cd7d6b5618ee8edffe490 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 05 Dec 2018 17:25:58 +0000 Reviewed-on: https://review.openstack.org/554352 Project: openstack-infra/zuul Branch: refs/heads/master
13 daysMerge "Fix "reverse" Depends-On detection with new Gerrit URL schema"Zuul
2018-12-03Don't calculate priority of non-live itemsJames E. Blair
Two earlier adjustments to the dynamic node priority removed non-live items from the count of items in the queue and then protected against the case where processOneItem attempted to calculate the priority of a non-live item. Instead, just avoid calling getNodePriority from processOneItem if the item is not live (it has no node requests), and for efficiency, remove the safety check in getNodePriority which should no longer be necessary. Change-Id: Ibcf26664f3721961d8e767776f2128ec4298ffd0 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 03 Dec 2018 18:07:44 +0000 Reviewed-on: https://review.openstack.org/621626 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-02web: refactor status page to use a reducerTristan Cacqueray
This change updates the status page component to use a fetchStatusAction instead of direct axios call. This enables using the generic error reducers. This change also refactors the refresh button into a parent component to enable re-use on the other pages. Change-Id: Iac8a317263f84f14f28d2ea015f918268b903407 Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 07 Dec 2018 07:04:00 +0000 Reviewed-on: https://review.openstack.org/621395 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-02web: add error reducer and info toast notificationTristan Cacqueray
This change adds a new error reducer to manage error from API calls. The info actions retries failed info request after 5 seconds. Change-Id: Ieb2b66a2847650788d9bf68080ab208855941f24 Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 06 Dec 2018 20:42:51 +0000 Reviewed-on: https://review.openstack.org/621387 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-02web: refactor info and tenant reducers actionTristan Cacqueray
This change adds info fetch state action type and simplifies the main App by using the new info attributes. Change-Id: I2cfd3f6ae605051e11f58272e62925d8f97e4ac9 Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 06 Dec 2018 19:35:16 +0000 Reviewed-on: https://review.openstack.org/621386 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-02web: break the reducers module into logical unitsTristan Cacqueray
This change applies best practices to split the current reducers module in logical unit. Each reducer and its actions are moved into different modules to ease further refactor and follow-up tests. Change-Id: I75cc41ca3d31a61046868aafbc84505de661a99d Notes (review): Code-Review+1: Artem Goncharov <artem.goncharov@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 06 Dec 2018 18:20:06 +0000 Reviewed-on: https://review.openstack.org/621385 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-01Merge "Remove nodeid argument from updateNode"Zuul
2018-12-01Merge "Only count live items for relative priority"Zuul
2018-12-01Merge "Fix updating relative priority"Zuul
2018-12-01Only count live items for relative priorityJames E. Blair
Non-live items in a pipeline don't have node requests, so don't penalize long patch series by counting the non-live ancestors of changes when calculating relative_priority. Change-Id: I7ec63e2ea4403087dd43c3b15eb703a2fa5542a7 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 01 Dec 2018 15:43:27 +0000 Reviewed-on: https://review.openstack.org/621315 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-01Fix updating relative priorityJames E. Blair
This code path was untested and had some typos. Correct them and ensure the path is tested. Change-Id: Ib4a283f739b12295f480684b9b93ad8a60abf350 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 01 Dec 2018 15:43:25 +0000 Reviewed-on: https://review.openstack.org/621319 Project: openstack-infra/zuul Branch: refs/heads/master
2018-12-01Merge "Fix permanently broken git cache"Zuul
2018-11-30Merge "Remove STATE_PENDING"Zuul
2018-11-30Merge "Clarify executor zone documentation"Zuul
2018-11-30Merge "Set relative priority of node requests"Zuul
2018-11-30Remove nodeid argument from updateNodeJames E. Blair
This function expects a node object with the .id attribute populated. Change-Id: Ic9fcc74a873760f45b23e9af7345d9bf998a41f1 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 01 Dec 2018 20:10:17 +0000 Reviewed-on: https://review.openstack.org/621047 Project: openstack-infra/zuul Branch: refs/heads/master
2018-11-30Set relative priority of node requestsJames E. Blair
Add a relative_priority field to node requests and continuously adjust it for each queue item based on the contents of queues. This allows for a more fair distribution of build resources between different projects. The first item in a pipeline from a given project (or, in the case of a dependent pipeline, group of projects) has equal priority to all other first-items of other projcets in the same pipeline. Second items have a lower priority, etc. Depends-On: https://review.openstack.org/620954 Change-Id: Id3799aeb2cec6d96a662bfa394a538050f7ea947 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 30 Nov 2018 15:24:56 +0000 Reviewed-on: https://review.openstack.org/615356 Project: openstack-infra/zuul Branch: refs/heads/master