summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
3 daysMerge "Add release note for broken trusted config loading fix"HEAD3.8.0masterZuul
3 daysMerge "Config errors should not affect config-projects"Zuul
3 daysMerge "Fix dynamic loading of trusted layouts"Zuul
3 daysAdd release note for broken trusted config loading fixClark Boylan
We should have this to make a release. Change-Id: If68512cf8816051a52edd60203c599a260cc0a7b Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 16 Apr 2019 02:29:31 +0000 Reviewed-on: https://review.openstack.org/652793 Project: openstack-infra/zuul Branch: refs/heads/master
4 daysConfig errors should not affect config-projectsPaul Belanger
Story: 2005452 Change-Id: I4e043025e06f83de0d29cfa239eccc3bdb376d04 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 16 Apr 2019 02:10:26 +0000 Reviewed-on: https://review.openstack.org/652788 Project: openstack-infra/zuul Branch: refs/heads/master
4 daysFix dynamic loading of trusted layoutsClark Boylan
There were special circumstances under which we would return a trusted config layout as a valid dynamic layout update. Specifically if there were existing layout errors in code unrelated to the trusted config update we would fall through error handling such that the trusted config would be returned. Fix this by recording the trusted and untrusted layouts as separate variables so that we can very clearly switch through our state cases and be clear that we never return the trusted_layout. Instead of there is a trusted_layout update that would otherwise be accepted we return the current pipeline config. Part of the fix here is to write out a "switch" table that clearly lists and handles all known possible cases. If we hit an unknown case we return an error. Hopefully by being extra clear about our intent we avoid unexpected behavior like this in the future. Story: 2005452 Change-Id: I095819bf2288b4101352badfaf0e0fa8062c2829 Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 16 Apr 2019 01:53:12 +0000 Reviewed-on: https://review.openstack.org/652787 Project: openstack-infra/zuul Branch: refs/heads/master
4 daysMerge "Reset dependent jobs when aborting paused job"Zuul
4 daysMerge "Centralize job canceling"Zuul
4 daysMerge "encrypt: Fix SSL error when using file pubkey"Zuul
6 daysMerge "web: add ErrorBoundary"Zuul
6 daysMerge "web: check if job has parent"Zuul
7 daysMerge "Handle github exceptions better when trying to get a PR"Zuul
9 daysMerge "Add database info for components graph"Zuul
9 daysHandle github exceptions better when trying to get a PRPaul Belanger
When we use getPull() function after a github event, it seems there might be race where the PR may not exist just yet. So, rather then raising an exception, log a warning and allow the loop to try again. Change-Id: I66aaa74e0fdeade253df1e44a659f513accdfe37 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 12 Apr 2019 00:09:55 +0000 Reviewed-on: https://review.openstack.org/651609 Project: openstack-infra/zuul Branch: refs/heads/master
9 daysMerge "Fix zuul-stream functional test"Zuul
9 daysMerge "Assert ara database is loaded from ansible venv"Zuul
9 daysMerge "tox: Fix indentation"Zuul
11 daysMerge "Set focus on xtem.js to terminal"Zuul
11 daysSet focus on xtem.js to terminalPaul Belanger
This allows a user to use PgUp/PgDn without first clicking the terminal. Change-Id: I315f9c8e264a291e4b0e38ecbd1a15dd8df2377c Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 08 Apr 2019 22:09:11 +0000 Reviewed-on: https://review.openstack.org/650275 Project: openstack-infra/zuul Branch: refs/heads/master
11 daysAssert ara database is loaded from ansible venvPaul Belanger
This adds some code coverage on zuul-executor side, to confirm ara database is also created by zuul-executor. Change-Id: I53cb3f96bf550bae2c736b1116ff2266056e926b Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 10 Apr 2019 08:09:01 +0000 Reviewed-on: https://review.openstack.org/650917 Project: openstack-infra/zuul Branch: refs/heads/master
12 daysencrypt: Fix SSL error when using file pubkeyLogan V
Fixes this: Traceback (most recent call last): File "zuul/tools/encrypt_secret.py", line 192, in <module> main() File "zuul/tools/encrypt_secret.py", line 109, in main pubkey = urlopen(req, context=ssl_ctx) When using a file://<path> URL for the project key. Change-Id: Ide5031eb95fda0d8932e20c178e46ba488ac1783 Notes (review): Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+1: Matthieu Huin <mhuin@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+1: melissaml <ma.lei@99cloud.net> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Code-Review+1: 98k <18552437190@163.com> Code-Review+1: Filippo Inzaghi <zhao.daqing@99cloud.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 15 Apr 2019 21:29:31 +0000 Reviewed-on: https://review.openstack.org/650589 Project: openstack-infra/zuul Branch: refs/heads/master
14 daysCheck branches in supercedent pipelinesJames E. Blair
Supercedent was designed for a post pipeline and predates common use of a promote pipeline. It therefore only consulted the 'ref' attribute of a change (so that it would work on tags as well as branches). However, it should work just fine as a manager for promote pipelines too, so have it check the branch attribute for de-duplication first, and only use the ref attribute if it isn't present. Change-Id: I1393c828b86a577fba568a183efee98cf5d030e7 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Clint 'SpamapS' Byrum <clint@fewbar.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 06 Apr 2019 00:44:24 +0000 Reviewed-on: https://review.openstack.org/650440 Project: openstack-infra/zuul Branch: refs/heads/master
14 daysTolerate missing projectTobias Henkel
Zuul fails to load if the tenant config references an inexistent or inaccessible project. This should not happen and also be added to the loading errors. This is especially important with github where users can freely rename, create and delete repos in their organizations. Change-Id: I99bc50e98c7edfd2767f950d4898ea8298d7ca94 Notes (review): Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 05 Apr 2019 18:43:49 +0000 Reviewed-on: https://review.openstack.org/579872 Project: openstack-infra/zuul Branch: refs/heads/master
14 daysMerge "Fix SQL error when querying for tuples"Zuul
14 daysFix zuul-stream functional testSimon Westphahl
The command 'ip addr show' has a differnet output format. Change-Id: Ida96686fd22a3c1d5d83b4688ae2ece19948a75d Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 10 Apr 2019 17:34:28 +0000 Reviewed-on: https://review.openstack.org/650297 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-05Merge "Whitelist pageup and down keys in xterm"Zuul
2019-04-04Use the buildset registry in zuul-quick-startJames E. Blair
The job no longer needs to build duplicate copies of the images, it can fetch them from the buildset registry instead. Change-Id: Ibcca12c20d29b9b45a67b65934e5a02087c8cdf8 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 23:59:23 +0000 Reviewed-on: https://review.openstack.org/649467 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-04Merge "Use opendev docker jobs"Zuul
2019-04-04Merge "Increase timeout of zuul-quick-start"Zuul
2019-04-04Fix SQL error when querying for tuplesJames E. Blair
When requiring more than one artifact zuul runs into an sql exception [1] which bubbles up to the run_handler. This effectively blocks all operations of zuul until the change that triggers this bug is dequeued. Fix this by correctly filtering the sql results. [1] Trace 2019-04-04 17:15:01,158 ERROR zuul.Scheduler: Exception in run handler: Traceback (most recent call last): File "/opt/zuul/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1244, in _execute_context cursor, statement, parameters, context File "/opt/zuul/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 552, in do_execute cursor.execute(statement, parameters) psycopg2.ProgrammingError: operator does not exist: character varying = record LINE 3: ...bc89ecf79fd84fc7c' AND zuul_provides.name = ('pro... ^ HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts. Change-Id: I7f95e1376b7a1f46a5b4ef5242c777e16ceca451 Co-Authored-By: Tobias Henkel <tobias.henkel@bmw.de> Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 05 Apr 2019 17:22:08 +0000 Reviewed-on: https://review.openstack.org/650086 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-04Whitelist pageup and down keys in xtermTobias Henkel
We currently block all keys in xterm so we can use ctrl+c for copying text. However this blocks scrolling via shift+pageup and down. Whitelist those buttons so scrolling per keyboard works. This blocks scrolling per keyboard. In case this is still needed we should add it back with a specific blacklist or whitelist. Change-Id: Ida8c90f556912941af528d3c1fd322cf1256185d Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: Clint 'SpamapS' Byrum <clint@fewbar.com> Workflow+1: Clint 'SpamapS' Byrum <clint@fewbar.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 05 Apr 2019 03:54:20 +0000 Reviewed-on: https://review.openstack.org/649694 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-03Merge "Fail jobs when requirements not met"Zuul
2019-04-03Merge "Add link to builds in job page"Zuul
2019-04-03Merge "Prepend path with bin dir of ansible virtualenv"Zuul
2019-04-03Merge "Add web / fingergw connections for components graph"Zuul
2019-04-02Use opendev docker jobsJames E. Blair
These utilize an intermediate registry and therefore honor dependencies. Change-Id: I46b02e1a9dd25a12a64a29535487f62d1f216674 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 21:31:48 +0000 Reviewed-on: https://review.openstack.org/649466 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-02Merge "Document how to run eslint locally"Zuul
2019-04-02Prepend path with bin dir of ansible virtualenvTobias Henkel
Tools like ara are now installed within the virtualenv where ansible is installed. We need to add the bindir of those into the path so ansible will find them. Change-Id: Ic8d0cf821222f792e892a765b2dccaa0f35653af Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 15:09:38 +0000 Reviewed-on: https://review.openstack.org/649427 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-02Add database info for components graphPaul Belanger
Update our diagram to show the connections needed if running a database. Change-Id: I67e47b1916ac1c3ad1f06b9b65c4b1e78aa6a55f Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 10 Apr 2019 22:30:00 +0000 Reviewed-on: https://review.openstack.org/649371 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-02Merge "Add search function to web streaming"Zuul
2019-04-02Increase timeout of zuul-quick-startTobias Henkel
The job zuul-quick-start shows a high rate of timeouts lately. Increase that to improve stability. Change-Id: Id6cd751c1cefc5a90cce2ecdd605dcf50d8a924a Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 20:35:06 +0000 Reviewed-on: https://review.openstack.org/649384 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-02Merge "Use xterm.js for live log streaming"Zuul
2019-04-02Add web / fingergw connections for components graphPaul Belanger
Show how zuul-web and zuul-fingergw need to connect to zuul-executors for log streaming. Change-Id: Ia985979c16d8276c13b1ba7ffbbb5a2224ccff01 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 05:03:04 +0000 Reviewed-on: https://review.openstack.org/645852 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-01Merge "web: Add '/' API route"Zuul
2019-04-01Merge "tox: Change default 'install_command'"Zuul
2019-04-01Merge "tox: Remove 'commands_pre'"Zuul
2019-04-01Merge "Resolve todo after stream.html to stream renaming"Zuul
2019-04-01Add search function to web streamingTobias Henkel
Using the search addon we can add search capabilities to the xterm.js based web streaming. This also supports regex, case sensitive/insensitive and whole word matches. Change-Id: Icc370c3fe5786d8f81e0c5fd6bd17b2989dda2c7 Notes (review): Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Code-Review+1: Vieri <15050873171@163.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 02 Apr 2019 17:18:27 +0000 Reviewed-on: https://review.openstack.org/648862 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-01Use xterm.js for live log streamingTobias Henkel
We currently use a very simplistic self written mechanism for live log streaming. This has severe performance drawbacks when dealing with large live logs. The component xterm.js widely used out there that is specialized for this task and handles huge logs just fine. We also don't need the autoscroll checkbox anymore as this is handled automagically by xterm.js. It stops following the stream when scrolling and starts following again after scrolling to the bottom. Further it makes it easy to have clickable links in the live log. Change-Id: I3492e983bf248b4f286edc1bf9db3d52297da993 Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Code-Review+1: Vieri <15050873171@163.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 02 Apr 2019 16:04:58 +0000 Reviewed-on: https://review.openstack.org/648838 Project: openstack-infra/zuul Branch: refs/heads/master
2019-04-01Merge "Fix slightly smaller font of in progress jobs"Zuul