Commit Graph

4 Commits

Author SHA1 Message Date
confi-surya e2bcc15c8d dict_object.keys() is not required for *in* operator
cleanup of .keys() from dict_object.keys() *in* operator

Change-Id: Ic79633899db628a7572840392933293426d0c187
2018-12-03 12:04:55 +05:30
Tobias Henkel f176bbda24
Normalize hostname for statsd
When doing the statsd reporting we need to normalize the
hostname. Otherwise if the hostname is an ip address we get scary
metrics like:

  zuul.executor.10.130.3.21.running_builds:0|g"

So we need to normalize these and replace the '.' and ':' by '_' like
we're doing that in nodepool.

Change-Id: Ide5517fb4a851f801c7ff0816d5e4f5876cc6401
2018-03-06 18:46:29 +01:00
James E. Blair 26ee6f406d Make statsd import failure raise exception
At this point, if a user has configured statsd, we assume we can
import it, so don't wrap the import in a try_import, just assume
it's going to work.

However, we still import within the method so that if statsd is not
configured, we don't attempt to import it.

Change-Id: I5f0041300c666a3d572f45f3709d5d64ad599c8a
2017-10-13 16:11:42 -07:00
James E. Blair ded241e598 Switch statsd config to zuul.conf
The automatic statsd configuration based on env variables has
proven cumbersome and counter-intuitive.  Move its configuration
into zuul.conf in preparation for other components emitting stats.

Change-Id: I3f6b5010d31c05e295f3d70925cac8460d334283
2017-10-13 14:04:42 -07:00