zuul
/
zuul
Code Issues Proposed changes

Merge "gerrit: use change: when querying changes"

This commit is contained in:
Zuul 2019-03-25 22:21:37 +00:00 committed by Gerrit Code Review
parent 2a29f5b0aa 846b77322a
commit 570a8ead7a
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/base.py
View File

@ -728,6 +728,11 @@ class FakeGerritConnection(gerritconnection.GerritConnection):
change.setReported()
def query(self, number):
if type(number) == int:
return self.queryChange(number)
raise Exception("Could not query %s %s" % (type(number, number)))
def queryChange(self, number):
change = self.changes.get(int(number))
if change:
return change.query()

7
zuul/driver/gerrit/gerritconnection.py
View File

@ -551,7 +551,7 @@ class GerritConnection(BaseConnection):
return change
self.log.info("Updating %s" % (change,))
data = self.query(change.number)
data = self.queryChange(change.number)
change._data = data
if change.patchset is None:
@ -683,7 +683,7 @@ class GerritConnection(BaseConnection):
# means it's merged.
return True
data = self.query(change.number)
data = self.queryChange(change.number)
change._data = data
change.is_merged = self._isMerged(change)
if change.is_merged:
@ -905,6 +905,9 @@ class GerritConnection(BaseConnection):
(pprint.pformat(data)))
return data
def queryChange(self, number):
return self.query('change:%s' % number)
def simpleQuery(self, query):
def _query_chunk(query):
args = '--commit-message --current-patch-set'