summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Henkel <tobias.henkel@bmw.de>2019-03-07 21:20:48 +0100
committerTobias Henkel <tobias.henkel@bmw.de>2019-03-07 21:20:48 +0100
commit80bac8d30c5b70b056f2baa22edfb5cec4610650 (patch)
treed3f9c0d997602d3cf28637310b5126356db33ea0
parent6a9d02983430cd2cad7b21d13cf21ff874e1e8ce (diff)
Fix test race in test_container_jobs
The test case test_container_jobs has a race. It asserts two jobs with enforced order. However the jobs triggered aren't forces into any particular order so in some cases the validation fails. Fix this by asserting unordered. Change-Id: I22908cf5b4ed0117cdb93b226f70cf4f9d851795
Notes
Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 11 Mar 2019 22:30:49 +0000 Reviewed-on: https://review.openstack.org/641791 Project: openstack-infra/zuul Branch: refs/heads/master
-rw-r--r--tests/unit/test_v3.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/unit/test_v3.py b/tests/unit/test_v3.py
index 5c21ce1..2b51505 100644
--- a/tests/unit/test_v3.py
+++ b/tests/unit/test_v3.py
@@ -4770,7 +4770,7 @@ class TestContainerJobs(AnsibleZuulTestCase):
4770 self.assertHistory([ 4770 self.assertHistory([
4771 dict(name='container-machine', result='SUCCESS', changes='1,1'), 4771 dict(name='container-machine', result='SUCCESS', changes='1,1'),
4772 dict(name='container-native', result='SUCCESS', changes='1,1'), 4772 dict(name='container-native', result='SUCCESS', changes='1,1'),
4773 ]) 4773 ], ordered=False)
4774 4774
4775 4775
4776class TestProvidesRequiresPause(AnsibleZuulTestCase): 4776class TestProvidesRequiresPause(AnsibleZuulTestCase):