zuul
/
zuul
Code Issues Proposed changes

Fix noop job toDict() 

The noop job doesn't have a source_context, this change fixes
the toDict() method to enable requesting noop job from the
REST API.

Change-Id: Ibf1999a168e523d53c13dfde3855921240c8b2ad
Story: 2004757
Task:  28863
This commit is contained in:
Tristan Cacqueray 2019-01-12 00:00:48 +00:00
parent 5fbc185236
commit 47452f9130
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/test_web.py
View File

@ -568,6 +568,10 @@ class TestWeb(BaseTestWeb):
resp = self.get_url("api/tenant/non-tenant/jobs")
self.assertEqual(404, resp.status_code)
def test_web_job_noop(self):
job = self.get_url("api/tenant/tenant-one/job/noop").json()
self.assertEqual("noop", job[0]["name"])
class TestInfo(BaseTestWeb):

5
zuul/model.py
View File

@ -1123,7 +1123,10 @@ class Job(ConfigObject):
d['irrelevant_files'] = self._irrelevant_files
d['variant_description'] = self.variant_description
d['implied_branch'] = self._implied_branch
d['source_context'] = self.source_context.toDict()
if self.source_context:
d['source_context'] = self.source_context.toDict()
else:
d['source_context'] = None
d['description'] = self.description
d['required_projects'] = []
for project in self.required_projects.values():