summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTristan Cacqueray <tdecacqu@redhat.com>2018-11-28 13:48:14 +0000
committerTristan Cacqueray <tdecacqu@redhat.com>2018-11-28 13:48:14 +0000
commit365ba836b8372fc9c4bdf1a342c79f7e29a3bf97 (patch)
tree9e310aea7408c178143d2bc43feaa1a7efec0907
parent8a58a358d12b719a4f45410c185b3df2e25f666c (diff)
web: fix ref column value for newrev
The substring call skipped the first character of newrevs. This changes fixes the split using a correct substr. Change-Id: I43c8ec2683fdf3da476531f54c30b2bd7742ec46
Notes
Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 28 Nov 2018 21:14:53 +0000 Reviewed-on: https://review.openstack.org/620602 Project: openstack-infra/zuul Branch: refs/heads/master
-rw-r--r--web/src/pages/Builds.jsx2
1 files changed, 1 insertions, 1 deletions
diff --git a/web/src/pages/Builds.jsx b/web/src/pages/Builds.jsx
index f01c359..314f5d7 100644
--- a/web/src/pages/Builds.jsx
+++ b/web/src/pages/Builds.jsx
@@ -74,7 +74,7 @@ class BuildsPage extends TableFilters {
74 ) 74 )
75 const linkChangeFormat = (value, rowdata) => ( 75 const linkChangeFormat = (value, rowdata) => (
76 <Table.Cell> 76 <Table.Cell>
77 <a href={rowdata.rowData.ref_url}>{value ? rowdata.rowData.change+','+rowdata.rowData.patchset : rowdata.rowData.newrev ? rowdata.rowData.newrev.substring(7,1) : rowdata.rowData.branch}</a> 77 <a href={rowdata.rowData.ref_url}>{value ? rowdata.rowData.change+','+rowdata.rowData.patchset : rowdata.rowData.newrev ? rowdata.rowData.newrev.substr(0, 7) : rowdata.rowData.branch}</a>
78 </Table.Cell> 78 </Table.Cell>
79 ) 79 )
80 this.columns = [] 80 this.columns = []