summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMonty Taylor <mordred@inaugust.com>2019-02-09 18:39:04 +0000
committerMonty Taylor <mordred@inaugust.com>2019-02-09 18:39:04 +0000
commita608f98b4fa2fef37731c110569b965082df9a33 (patch)
tree1b7e8355bf1914b437a119243059c5a86653821f
parent52ba519ce2cc4ea00c01ad3b03d11a22f844060c (diff)
Clean up a few more warning settings
We had a few things turned off in drizzle because of the inherited codebase and the pain of cleaning them up. Turn them back on. Also, we don't actually need the additional lib settings in the libcpprest test.
-rw-r--r--m4/pandora_have_libcpprest.m42
-rw-r--r--m4/pandora_warnings.m46
2 files changed, 3 insertions, 5 deletions
diff --git a/m4/pandora_have_libcpprest.m4 b/m4/pandora_have_libcpprest.m4
index 2d05e63..5c8d1b9 100644
--- a/m4/pandora_have_libcpprest.m4
+++ b/m4/pandora_have_libcpprest.m4
@@ -29,8 +29,6 @@ AC_DEFUN([_PANDORA_SEARCH_LIBCPPREST],[
29web::http::client::http_client client("http://example.com/"); 29web::http::client::http_client client("http://example.com/");
30 ]) 30 ])
31 CXXFLAGS="${save_CXXFLAGS}" 31 CXXFLAGS="${save_CXXFLAGS}"
32 LIBCPPREST="${LIBCPPREST} ${PTHREAD_LIBS}"
33 LTLIBCPPREST="${LTLIBCPPREST} ${PTHREAD_LIBS}"
34 AC_LANG_POP() 32 AC_LANG_POP()
35 ],[ 33 ],[
36 ac_cv_libcpprest="no" 34 ac_cv_libcpprest="no"
diff --git a/m4/pandora_warnings.m4 b/m4/pandora_warnings.m4
index cd18a19..38a4281 100644
--- a/m4/pandora_warnings.m4
+++ b/m4/pandora_warnings.m4
@@ -185,8 +185,8 @@ foo();
185 [ac_cv_safe_to_use_wformat_=no]) 185 [ac_cv_safe_to_use_wformat_=no])
186 CFLAGS="$save_CFLAGS"]) 186 CFLAGS="$save_CFLAGS"])
187 AS_IF([test "$ac_cv_safe_to_use_wformat_" = "yes"],[ 187 AS_IF([test "$ac_cv_safe_to_use_wformat_" = "yes"],[
188 BASE_WARNINGS="${BASE_WARNINGS} -Wformat -Wno-format-nonliteral -Wno-format-security" 188 BASE_WARNINGS="${BASE_WARNINGS} -Wformat=2"
189 BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2 -Wno-format-nonliteral -Wno-format-security" 189 BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wformat=2"
190 ],[ 190 ],[
191 BASE_WARNINGS="${BASE_WARNINGS} -Wno-format" 191 BASE_WARNINGS="${BASE_WARNINGS} -Wno-format"
192 BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wno-format" 192 BASE_WARNINGS_FULL="${BASE_WARNINGS_FULL} -Wno-format"
@@ -238,7 +238,7 @@ uint16_t x= htons(80);
238 ]) 238 ])
239 239
240 CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}" 240 CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}"
241 CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy -Wno-long-long ${CXX_WARNINGS_FULL}" 241 CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy ${CXX_WARNINGS_FULL}"
242 242
243 AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++], 243 AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++],
244 [ac_cv_safe_to_use_Wmissing_declarations_], 244 [ac_cv_safe_to_use_Wmissing_declarations_],