Commit Graph

8 Commits

Author SHA1 Message Date
Ian Wienand 6d23d20f2f linters: add names to blocks
This is preparation for a later version of ansbile-lint, which finds
missing names on blocks.  This seems a reasonable rule, and the
Ansible manual says [1]

  Names for blocks have been available since Ansible 2.3. We recommend
  using names in all tasks, within blocks or elsewhere, for better
  visibility into the tasks being executed when you run the playbook.

This simply adds a name tag for blocks that are missing it.  This
should have no operational change, but allows us to update the linter
in a follow-on change.

[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html

Change-Id: I92ed4616775650aced352bc9088a07e919f1a25f
2022-07-27 17:13:39 +10:00
Andreas Jaeger 54077ba1e1 Fix condition in version-from-git
This should be the negation of the condition above, not exactly the same
but double negated.

Change-Id: I24e5f73480c83777f8dcb5ca71283afe5565212f
2018-03-07 08:25:18 +00:00
Andreas Jaeger 9ff13740f8 Fix version-from-git syntax
Fix "Syntax Error while loading YAML" with proper ordering of block.

Change-Id: I8a59856dbc91bec03adf193128ca6cc0ff7a7b54
2018-03-07 07:51:45 +01:00
Monty Taylor a966445c16 Handle repos with no tags in version-from-git
The version-from-git role doesn't properly handle tag-less repos. Update
it to handle that case too.

Change-Id: I358037fd34f5dc202a6761b9e6f81bbe7870f3f2
2018-03-06 19:14:06 +00:00
Emilien Macchi d6d835e414 version-from-git: fix logic with tags
When there is no commit since the tag, we don't want the scm_sha part of
project_ver, but just the scm_tag. This patch fix the logic.

Change-Id: I89e59049fe65ebc49fc03f205affa68b8fa5beb9
2017-11-03 16:05:53 -07:00
Andreas Jaeger 6a278c011c Silence ansible-lint
These warnings are ok, disable them.

Change-Id: Ida5ecc81fdaed137ac10baa51643962a5e97b89d
2017-10-27 06:10:31 +02:00
Andreas Jaeger d8b9239324 Silence ansible-lint
Add tags to tell ansible-lint to ignore the problems found since
those are false positives.

Needed-By: I16186c929e7d0e6e34b35271559e555255a52b00
Change-Id: I59e5d41a9539671ee5aab9b9036379eb9101d021
2017-10-25 13:17:16 +00:00
Monty Taylor ad1ce4fc2f
Add base job and roles for javascript
This is in service of getting javascript tarball jobs going.

Change-Id: I20b4b4ce0bdf03c5585ca73471611178c94e2599
2017-10-09 08:32:45 -05:00