Commit Graph

9 Commits

Author SHA1 Message Date
Sorin Sbarnea 0eaa5cf59a Upgrade ansible-lint to 5.0
- bumps ansible-lint to 5.0
- updates our custom rules to make them compatible with 5.0
- replace custom module mocking with native ansible-lint ones
- remove custom call of ansible-playbook --syntax-check as now this
  is done by ansible-lint
- assured molecule vars are hosted under a vars/ folder in order to
  avoid confusing linter detection.
- replaced custom rule for loop var names in role as now this this an
  optional core feature of the linter (see config)
- replaced custom rule no-same-owner with opt-in one (see config)

Change-Id: I233fae8c9036d295968a97ee80e07fde8846c633
2021-03-17 15:44:43 +00:00
Albin Vass 86b6edb421 revoke-sudo: delete cloud-config sudoers file
Change-Id: Icc3d1b4122d5328dd900d8ce581755f53030ed21
2020-11-13 15:58:38 +01:00
Tristan Cacqueray 892dc6a095 revoke-sudo: only revoke when zuul is sudoer
This change makes unittests jobs usable on read-only environment.

Change-Id: I36cfe7e5849687dbed510396a825dc0ec45542b3
2017-12-05 08:36:26 +00:00
Andreas Jaeger d8b9239324 Silence ansible-lint
Add tags to tell ansible-lint to ignore the problems found since
those are false positives.

Needed-By: I16186c929e7d0e6e34b35271559e555255a52b00
Change-Id: I59e5d41a9539671ee5aab9b9036379eb9101d021
2017-10-25 13:17:16 +00:00
Monty Taylor 20aed09893 Remove the right file in revoke-sudo
Also fix the negative test to use shell instead of command, so that
! is parsed as intended.

Change-Id: I9f9dd60a895798cc639863a36b921b64621f6767
2017-09-28 20:15:17 +00:00
Paul Belanger 829297c37a
Ensure we load roles for linting
Did didn't have ansible-lint setup properly, as a results our roles
weren't actually linted properly.

Fix variable linting issues and ignore ANSIBLE0012.

Change-Id: I07aa940245e700c9f08df0f1920720f0ed9d3de0
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2017-07-17 16:50:06 -04:00
Monty Taylor 3dc03ee0d6
Rename zuul-revoke-sudo to revoke-sudo
Depends-On: If639d35ded59621c38d0ecb16344817fd176c31c
Change-Id: I51454b86b5d8b6c3c26615437a3b7ce386134435
2017-07-06 19:14:53 -05:00
Monty Taylor 4b9fc09a1c
Port in tox jobs from openstack-zuul-jobs
The original idea was that we'd have a "python27" job. But it turns out
that "python27" isn't actually as universal as you might think.
"tox-py27" on the other hand is a thing that can and should always work
for people who want to run tox with the py27 env.

Port in the jobs we had in openstack-zuul-jobs.

Also, copy in the text of the old shell scripts so that we can iterate on
them and make them better piecemeal.

These are named zuul-tox not tox because we already have tox jobs
defined elsewhere. We'll need to do the naming dance while we work on
them.

Change-Id: I813f3f2ae138c07918556bc81655518023527131
2017-07-06 11:18:47 -05:00
James E. Blair 46684654cb Add revoke-sudo role
Also add a .gitignore and establish a documentation pattern.

Change-Id: Ib447ac13d03de4ab61171d50b19117ff654ad329
Co-Authored-By: Paul Belanger <pabelanger@redhat.com>
2017-06-08 15:19:43 -07:00