Commit Graph

8 Commits

Author SHA1 Message Date
James E. Blair 9e22cfdb0f Remove shebang from all python ansible modules
This commit in Ansible:
9142be2f6c

now allows Python modules to specify their interpreter with the shebang.
We expect our roles to use the discovered python interpreter on remote
nodes, and on the executor, we need them to use the virtualenv.  Removing
the specific shebang accomplishes this under Ansible 6, and has no effect
under older versions of Ansible.

Without this, for example, the log upload roles would not have access to
their cloud libraries.

Also update our ansible/cli check in our module files.  Many of our modules
can be run from the command line for ease of testing, but the check that we
perform to determine if the module is being invoked from the command line
or Ansible fails on Ansible 5.  Update it to a check that should work in
all 4 versions of Ansible that Zuul uses.

Change-Id: I4e6e85156459cca032e6c3e1d8a9284be919ccca
2022-09-15 13:48:10 -07:00
Monty Taylor 6ab78932a4 Set ignore_basepython_conflict to true
Otherwise we miss that we're not using 3.8 in the 38 env.

Fixes the cgi.escape issue that we didn't catch earlier.

Change-Id: I604bd18b70950580f60714598624d493f4a5060f
2020-05-09 20:43:52 +00:00
Albin Vass d0e2016592 Add loop var policy to ansible-lint
This adds a custom ansible-lint rule at .rules/ZuulJobsNamespaceLoopVar.py
that enforces the loop var policy described at:
https://zuul-ci.org/docs/zuul-jobs/policy.html#ansible-loops-in-roles

It also updates existing roles to follow the policy.

Change-Id: I92b2ff56a1c2702542fc07b316f1809087a4c92f
2020-04-29 17:20:59 +02:00
Monty Taylor 20c7a54390 Update more urls for opendev
Change-Id: I6a29bfb583078497ceaaf2dda047ebfb92642b24
2019-04-21 14:01:15 +00:00
James E. Blair 74b5e0a1b3 htmlify: don't log
Don't log the complete stat output of every file we htmlify, it's
boring.

Change-Id: I72e6b6234361430a3a7a67f1235c797be4c0059e
2018-08-20 13:00:18 -07:00
James E. Blair 15ba4de7e6 htmlify: fix py3 gzip issue
Actually test the gzip path, and correct a bytes/str issue under
python3 (the file should be opened as text).

Change-Id: Icc5362d3d020761e07e60fb8ee296c98a8fe3ac4
2018-08-17 13:12:39 -07:00
Ian Wienand eee316ce7b Enable Python 2.7 unit tests
Add a testenv:py27 environment that overrides basepython to 2.7

Unfortunately implicit namespace packages are a Python3 thing [1] so
we have to scatter a few __init__.py's around for the test loader
under python2 to be able to find the unit test directories.

Update documenation to mention this

Needed-By: https://review.openstack.org/592768

[1] https://www.python.org/dev/peps/pep-0420/

Change-Id: I9a653666e8a083fb7f3fbb92589fe0467a41e6e6
2018-08-17 10:23:20 +10:00
James E. Blair 3f6190cb65 Add HTMLify logs role
A simple role to make HTML versions of all files with .txt
extensions.

Co-Authored-By: Tobias Henkel <tobias.henkel@bmw.de>
Change-Id: Ia5feac28a23df37965e50de726a1caa821b546ad
2018-08-02 13:11:34 -07:00