Commit Graph

8 Commits

Author SHA1 Message Date
Ian Wienand 6d23d20f2f linters: add names to blocks
This is preparation for a later version of ansbile-lint, which finds
missing names on blocks.  This seems a reasonable rule, and the
Ansible manual says [1]

  Names for blocks have been available since Ansible 2.3. We recommend
  using names in all tasks, within blocks or elsewhere, for better
  visibility into the tasks being executed when you run the playbook.

This simply adds a name tag for blocks that are missing it.  This
should have no operational change, but allows us to update the linter
in a follow-on change.

[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html

Change-Id: I92ed4616775650aced352bc9088a07e919f1a25f
2022-07-27 17:13:39 +10:00
Luigi Toscano 82828cea50 fetch-coverage-output: direct link to coverage data
Make it easier to find them.

Change-Id: I0e8ee7e3c9f6e55461168b97525b26625eb018f0
2020-07-06 01:03:00 +02:00
Albin Vass ca1a1b0e8a fetch-coverage-output: do not synchronize owner
Change-Id: Ief5b58480bd97d48cf3320f28f1ad0acd3d3fe17
2020-05-18 17:04:10 +02:00
Julia Kreger 3f4279c4fa Fix coverage post_failure stat
Fix ansible syntax error for the coverage job as register
is a higher level action, not a module argument.

Ansible is reporting: Unsupported parameters for (stat) module: register

Change-Id: I69f46b116993c5d55d6b9909c361e07b4e0dc92b
2018-07-22 09:46:01 -04:00
Goutham Pacha Ravi 046278c147 Attempt to copy the coverage report even if job fails
Some cover jobs such as the one in openstack/manila [1]
run custom coverage jobs and zuul_success=false doesn't
always mean that the 'coverage' tool itself has failed
to run.

So, attempt to copy the coverage report if it exists.

[1] http://git.openstack.org/cgit/openstack/manila/tree/tools/cover.sh

Change-Id: I5487f8c6ba8185fa0bfe7d83d24df3e065e0a903
2018-07-16 20:27:09 +00:00
Monty Taylor b6adb9a8c4 Don't fetch coverage report from failing tests
When test runs fail, coverage reports are not generated. We try to fetch
them anyway, which leads to POST_FAILURE instead of FAILURE.

Add in a check to ensure the test run was successful, then a check for
the coverage dir and an explicit error message so that it's clear to
people that the issue is that coverage wasn't generated after a
successful run, rather than there being an issue with rsync or
something.

Change-Id: I07f942a9df518d6602ee151d82b35ce413769c73
2018-01-17 19:53:57 +01:00
Ian Wienand 75d7e47287 Correct path to coverage job
Seems we added an extra "cover" in
Ibad091f7630832eb993133b0f43a60931b3dfd75

Also, correct the copy path so we copy the directory "cover"
separately

Change-Id: I4966342efd1a3d00c47394de054f81a1d89183c7
2017-10-19 14:49:53 +11:00
Tom Barron 74a40ec89e Collect output from coverage job
Add a post-run playbook to tox-cover job to collect the coverage
report detail and copy it to the log root of the executor.

Change-Id: Ibad091f7630832eb993133b0f43a60931b3dfd75
2017-10-17 21:58:36 -04:00