This is preparation for a later version of ansbile-lint, which finds
missing names on blocks. This seems a reasonable rule, and the
Ansible manual says [1]
Names for blocks have been available since Ansible 2.3. We recommend
using names in all tasks, within blocks or elsewhere, for better
visibility into the tasks being executed when you run the playbook.
This simply adds a name tag for blocks that are missing it. This
should have no operational change, but allows us to update the linter
in a follow-on change.
[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html
Change-Id: I92ed4616775650aced352bc9088a07e919f1a25f
This fixes a number of places where we do not have spaces between
filters. I think that this is a reasonable rule for readability (I
also think it probably was enforced, but maybe later versions got
better at detecting it?).
These are detected by a later version of Ansible lint; this change
should have no operational change to any roles but prepares us to
update in a follow-on change.
Change-Id: I07e1a109b87adce86f483d14d7e02fcecb8313d5
This marks this particular ignore_errors as safe. Generally I think
the rule is good, in that tasks get marked as failed when using
ignore_errors which is confusing and hard to debug. But in this case
it's because of missing hostnames
(I8d67d8aa284b6ce9ae012608e8f1b12784ce836b) and not something we can
catch easily.
Change-Id: I9b5d6a85254f689e97bca91951632b4dea60cfde
When you're running a multi-node job, it would be nice to see the
inventory hostname in this list, so if you want to say, monitor one of
the nodes, you don't have to guess which is which.
Change-Id: Ibf822d51711c74d963a7287eaeaa9a40ff074e79
This adds a custom ansible-lint rule at .rules/ZuulJobsNamespaceLoopVar.py
that enforces the loop var policy described at:
https://zuul-ci.org/docs/zuul-jobs/policy.html#ansible-loops-in-roles
It also updates existing roles to follow the policy.
Change-Id: I92b2ff56a1c2702542fc07b316f1809087a4c92f
Adds information that is can be key regarding the outcome of the job:
* distribution name
* distribution version
Change-Id: I8362ef2f0a89de4c318f13c874b6f083a4f1699f
For logs stored in object storage services we want to be able to shard
into different containers. This improves scalability of the object
stores. To do this consistently we prefix all log paths with the first 3
characters of the build uuid. This way we get container names like
log_123, log_abc, and so on for a total of 4096 containers.
This behavior is off by default because users of filesystems stores
without a zuul dashboard may still want periodic/ to be filed into a top
level dir for browseability.
Change-Id: I8e72a6e587edcbdf89b793cad2d7c96c535601e7
Both on logs.o.o and vexxhost swift object-storage, without a trailing
slash, a request will get 301 to new location with trailing slash. By
adding a trailing slash here, and since this is usually a directory, we
can avoid a 301 redirect for browsers.
Note, zuul_return for zuul upload-logs and upload-logs-swift does
include trailing slash.
Change-Id: Ie58f3922680806a5c1865a44bb379ef66e2992fd
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This task may be failing when ansible_hostname is not available:
The task includes an option with an undefined variable.
The error was: 'dict object' has no attribute 'ansible_hostname'
Change-Id: I8d67d8aa284b6ce9ae012608e8f1b12784ce836b
This is breaking project-config, and some reason we didn't catch it in
testing. We should look into why that is.
Change-Id: I994484cdb28297fdff8c52ccf7455733584cd8ae
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This currently fails with "Error 'nodepool' is undefined".
REmove nodepool line completely for now.
Change-Id: I134079a6118c8825fa91920c0f12c2d2789361a5
As we look towards updating the version of Ansible zuul is running with,
letting people know what version it is would be friendly.
Change-Id: I09cd990af5365a8da3c339eede128166a76b35dd
The nodepool provider variable is not always available, for example
when running only on localhost, so default it to "N/A".
Additionally, we don't want these tasks to run multiple times if we
are running a multi-node job so use "run_once: yes" to prevent
printing the header more than once.
This reverts commit 27755ba83f.
Depends-On: Ia79a793200fcb89161783ff641b85106936084b5
Change-Id: Id9117935d9c53268ea893796154af03db21ee3a7
Fix a few problems noticed when using this in project-config:
* Ignore apt-get warning in configure-mirrors
* All tasks should be named in upload-logs, emit-job-header
* use git_config in mirror-workspace-git-repos
* Ignore git warnings in mirror-workspace-git-repos
Change-Id: Ibcdc8d5a42fb081b5faa0cc89460e4cf88d369ba
These are helpful to understand the context of a running job before
logs are collected and made available.
Change-Id: I33f3f425a8008534c617422a7f77255a34f86198
Depends-On: I8d014464b3ed580d4a0fc6dbdc9a42601ff107e5
There are no playbooks that use the roles in this repo in a way that
would lint them, however running linters in project-config found
numerous issues in these roles. Correct the roles.
Change-Id: I017532c8aed8fd90474052423c7ba2510cf84631
Signed-off-by: Jesse Keating <omgjlk@us.ibm.com>
Make log_path zuul_log_path because log_path is rather generic.
Rename generate-log-url to set-zuul-log-path-fact to make it
clearer what it does.
Change-Id: I91ae1e396b3ef04939edebaeea8e5b16cc50315a
It contains the URL of the change being tested as well as the location
the logs are going to be found in.
Change-Id: I28bcd1c004bc399d3404e3c6a1f44fdfe98cf97d
Ian Wienand