summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
7 hoursMerge "Add a note on testing trusted roles"HEADmasterZuul
14 hoursMerge "Update test-mirror-workspace-git-repos, add test"Zuul
25 hoursAdd a note on testing trusted rolesIan Wienand
Add a general note on testing, and specifically on how to use test roles for testing trusted roles in the gate. Change-Id: Idf84bc56effbb21f7b7a82703f398fb203c3694b Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Code-Review+2: Jens Harbott (frickler) <j.harbott@x-ion.de> Workflow+1: Jens Harbott (frickler) <j.harbott@x-ion.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 18 Dec 2018 14:26:46 +0000 Reviewed-on: https://review.openstack.org/624578 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
32 hoursAlwas use pathless docker mirror URIJens Harbott
It seems that we need the pathless docker mirror URI for distro docker now, too, so set it unconditionally. Change-Id: Ic6918312ec60efba0397b85ee16d91c6393ee90b Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+1: Jean-Philippe Evrard <jean-philippe@evrard.me> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Workflow+1: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 17 Dec 2018 16:07:26 +0000 Reviewed-on: https://review.openstack.org/625596 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
6 daysVendor the RDO repository configuration for installing OVSDavid Moreau Simard
Installing OVS on CentOS requires one RDO repository and the centos-release-openstack packages sets up two additional repos which aren't required. In addition, we removed the centos-release-openstack package but this did not remove the two extra repositories, causing them to "leak" into the jobs. This sets up the one repository we need and ensures it is removed after OVS is installed. Change-Id: Ida2299a4356282d23b79fac6753b6171211a7651 Notes (review): Code-Review+2: Ian Wienand <iwienand@redhat.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 14 Dec 2018 16:44:13 +0000 Reviewed-on: https://review.openstack.org/624817 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
7 daysUpdate test-mirror-workspace-git-repos, add testIan Wienand
This updates the test-mirror-workspace-git-repos to be the same as mirror-workspace-git-repos, and adds the change proposed in I84d9a8a460e99d3bc558b3a7584d787b22f2ed33 for testing. Change-Id: If0792190c75c7716e94f1f5ae0f2d4fc37e0b306 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 18 Dec 2018 07:26:29 +0000 Reviewed-on: https://review.openstack.org/624575 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-30Merge "upload-logs-swift: Make indexer more generic"Zuul
2018-11-30Merge "upload-logs-swift: Cleanup temporary directories"Zuul
2018-11-28Create yarn_lock_file_path variable for install-yarnPaul Belanger
This removes the hardcoded path to yarn.lock and allows a user to define it manually. Change-Id: Ib29c7d442fd57e583674ba86bdc0d5edfac844c9 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 28 Nov 2018 18:59:57 +0000 Reviewed-on: https://review.openstack.org/620628 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-28upload-logs-swift: Make indexer more genericIan Wienand
This converts the Indexer class from something that strictly generates index.html files for folders to a more generic class that will be able to hold other types of transformations we might like to do on the total collections of uploaded files. The index.html specific arguments are moved into make_indexes() and the two helper functions that should not be called externally are renamed private. Change-Id: I388042ffb6a74c3200d92fb3a084369fcf2cf3a9 Notes (review): Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 30 Nov 2018 04:50:11 +0000 Reviewed-on: https://review.openstack.org/592852 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-28upload-logs-swift: Cleanup temporary directoriesIan Wienand
Add a function to the FileList context manager to get a temporary directory; keep track and remove these on exit. Use this in the index creation. Change-Id: I9d9220ad70ce191af02ae0331c98eafe487d96d4 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 30 Nov 2018 04:49:14 +0000 Reviewed-on: https://review.openstack.org/592340 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-22Merge "upload-logs-swift: Keep the FileList in the indexer class"Zuul
2018-11-22Merge "upload-logs-swift: Turn FileList into a context manager"Zuul
2018-11-20Merge "mirror-workspace-git: use port when pushing git repo through ssh"Zuul
2018-11-20Merge "Revert "validate-host: retry network tests and include unbound logs""Zuul
2018-11-19mirror-workspace-git: use port when pushing git repo through sshTudor Tabacel
In the case of using a custom SSH port to connect to the ansible host, the task of pushing the repository failed, as it assumed the SSH port to be the default 22. Now the command is aware of the custom SSH port, as it is specified in the host facts. Note that we have to escape the hostname if it is an ipv6 address (because : is a special character in ipv6 addresses). Thankfully ansible provides a filter to do that for us: https://docs.ansible.com/ansible/2.5/user_guide/playbooks_filters_ipaddr.html#wrapping-ipv6-addresses-in-brackets Change-Id: I76969850fc3a57078370fe38efdebac146720797 Notes (review): Code-Review+1: Doug Hellmann <doug@doughellmann.com> Code-Review+1: Logan V <logan2211@gmail.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 20 Nov 2018 17:26:53 +0000 Reviewed-on: https://review.openstack.org/618859 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-19Revert "mirror-workspace-git: use port when pushing git repo through ssh"Clark Boylan
This reverts commit 34cfe44ca5c63c354339aa502052d9054a36bf60. The :port suffix doesn't work if the hostname is an ipv6 ip address as the hostname needs to be wrapped in []s in that case. Revert this so that we can fix this in a followup. Change-Id: I2dfee56d40a4cdd096946a2f67c37117fff74cce Notes (review): Code-Review+1: Doug Hellmann <doug@doughellmann.com> Code-Review+1: Logan V <logan2211@gmail.com> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Verified+2: Clark Boylan <cboylan@sapwetik.org> Submitted-by: Clark Boylan <cboylan@sapwetik.org> Submitted-at: Mon, 19 Nov 2018 22:41:11 +0000 Reviewed-on: https://review.openstack.org/618849 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-19Revert "validate-host: retry network tests and include unbound logs"Paul Belanger
This reverts commit 7e00ba32dab04ac6a3f952d84dfd9eef1e021e47. Change-Id: I2c1aa1e834d408de14ad4818ff5c9b58145f44b0 Notes (review): Code-Review+1: Logan V <logan2211@gmail.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 20 Nov 2018 02:16:33 +0000 Reviewed-on: https://review.openstack.org/618844 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-19Merge "Remove mimetype check when calculating size"Zuul
2018-11-19Remove mimetype check when calculating sizeTobias Henkel
We currently try to skip size formatting for folders. However we compare with a bogix mimetype so the check is false in every case. Further folders typically have a size of 512 bytes or 4k. In both cases we don't really need to skip the size formatting so instead of fixing the check just skip it and do the size formatting unconditionally. Change-Id: I7ef021381bb56acf4b22551cc5d5613470fd6d08 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 19 Nov 2018 21:29:49 +0000 Reviewed-on: https://review.openstack.org/588150 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-19Merge "Add role git-prepare-nodecache"Zuul
2018-11-19Merge "mirror-workspace-git: use port when pushing git repo through ssh"Zuul
2018-11-19Merge "Add prepare-workspace-git role"Zuul
2018-11-19Merge "validate-host: retry network tests and include unbound logs"Zuul
2018-11-09Add role git-prepare-nodecacheTobias Henkel
The git-prepare-nodecache is a companion role that can be used to create a git cache suitable to be used by the prepare-workspace-git role. Change-Id: I623eb8abc64d956069b4f18d7a1d61383a705ac9 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 19 Nov 2018 19:57:10 +0000 Reviewed-on: https://review.openstack.org/616946 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-09mirror-workspace-git: use port when pushing git repo through sshTudor Tabacel
In the case of using a custom SSH port to connect to the ansible host, the task of pushing the repository failed, as it assumed the SSH port to be the default 22. Now the command is aware of the custom SSH port, as it is specified in the host facts. Change-Id: I3418016ad5a57e3024a8a553340a7e69b7d1c2fe Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+1: melissaml <ma.lei@99cloud.net> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 19 Nov 2018 19:48:05 +0000 Reviewed-on: https://review.openstack.org/616941 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-08enable setting python version for ensure-twineDoug Hellmann
Add twine_python so we can control the version of python used to install twine. Change-Id: I36ddbdf78f549ddc022cce86f3ada9631fb19c37 Signed-off-by: Doug Hellmann <doug@doughellmann.com> Notes (review): Code-Review+1: Aakarsh <agopi@redhat.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 08 Nov 2018 21:16:58 +0000 Reviewed-on: https://review.openstack.org/616673 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-08Merge "install-kubernetes: enable minikube version pinning"Zuul
2018-11-08install-kubernetes: enable minikube version pinningTristan Cacqueray
This change enables using a particular version of minikube for debugging purpose. Change-Id: Ide264165f12185e8313a16b6b6286ab74b32aa15 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 08 Nov 2018 10:30:28 +0000 Reviewed-on: https://review.openstack.org/616388 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-08install-docker: add package version optionIan Wienand
Add a variable to allow selecting a specific docker version. Useful if a new docker releases but your jobs aren't quite ready. Change-Id: Ie4c178d966474476fd2de4489738e47e8a641834 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 08 Nov 2018 10:23:09 +0000 Reviewed-on: https://review.openstack.org/616391 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-06validate-host: retry network tests and include unbound logsIan Wienand
Split the network testing component of the validate-host rule into a separate task, so it can be retried a couple of times in case something is a bit slow about bringing up external networking. Add failure collection of unbound logs if they appear to be in some common locations (such as will be there on infra nodes). Change-Id: Id12f1ba064fa2e5f75b9a5cfba76d238d23d3f57 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 19 Nov 2018 19:34:53 +0000 Reviewed-on: https://review.openstack.org/615698 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-11-05Merge "Add role to install kubernetes"Zuul
2018-10-31Add role to install kubernetesDavid Shrewsbury
Optionally, and by default, installs a Minikube cluster that runs locally. Change-Id: Ie6d0b73e6b3bdb77eee133a5f663133fd037aba0 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 05 Nov 2018 12:48:55 +0000 Reviewed-on: https://review.openstack.org/605823 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-31Merge "Updated bindep to cover for MacOS requirements"Zuul
2018-10-31Add prepare-workspace-git roleTobias Henkel
Currently the incremental push of the git repos to the nodes is split into a part in project-config and a part in zuul-jobs and only works within the OpenStack context. The prepare-workspace-git role is an attempt to make this generically available in zuul-jobs. It first checks for each needed project if it's cached. If yes it's cloned to the destination, if not it's just initialized as an empty git repo. After that we can generically use git operations to sync the correct state of the repos to the destination. Change-Id: I87938a02d51e561b25ca2cb20f53d62f3cd3ae73 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+1: melissaml <ma.lei@99cloud.net> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 19 Nov 2018 19:40:40 +0000 Reviewed-on: https://review.openstack.org/613036 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-28Fix noqa warningAndreas Jaeger
Change Ibfbd5df21e01d5a7bd44a216ff63bc805dd5c186 added the noqa to silence the warning - the real fix is to use a raw string for the regex that gets passed in. Change-Id: I986961082e0252547ca0b7e2cade3167459edf9b Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 30 Oct 2018 00:10:25 +0000 Reviewed-on: https://review.openstack.org/613785 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-27Updated bindep to cover for MacOS requirementsSorin Sbarnea
Enable testing with tox on MacOS. Change-Id: I2c64dec6b82e456537e35dcb8c5f1ed6a481afd7 Notes (review): Code-Review+2: Joshua Hesketh <josh@nitrotech.org> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 31 Oct 2018 05:19:25 +0000 Reviewed-on: https://review.openstack.org/613727 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-27Add missing optional dependencies to ensure-twineSorin Sbarnea
Avoids potential twine execution cause by: https://github.com/pypa/readme_renderer/issues/128 Resolves: UserWarning: Markdown renderers are not available. Install 'readme_render[md]' to enable Markdown rendering. Example: http://logs.openstack.org/25/613725/1/check/test-release-openstack-python3/df34317/job-output.txt.gz Change-Id: Iaf4da5aedaa3814b2ecebed4391da2324d3e388d Notes (review): Code-Review+1: Sean McGinnis <sean.mcginnis@gmail.com> Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sun, 28 Oct 2018 05:21:25 +0000 Reviewed-on: https://review.openstack.org/613726 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-27Makes queue import cross py2/py3 compatibleSorin Sbarnea
See http://logs.openstack.org/26/613726/2/check/tox-py27/c389283/job-output.txt.gz Change-Id: I1f1fc7b9393cfa44cfb3ba06ee06185fc7569d3a Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+1: Chandan Kumar <chkumar@redhat.com> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 27 Oct 2018 13:38:16 +0000 Reviewed-on: https://review.openstack.org/613728 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-25Fix flake8 3.6.0 errorsAndreas Jaeger
Flake8 3.6.0 now warns about both line break after and *before* binary operator, you have to choose whether you use W503 or W504. Disable the newer W504. Also, ignore warning about invalid escape sequence in regex. Change-Id: Ibfbd5df21e01d5a7bd44a216ff63bc805dd5c186 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 25 Oct 2018 07:37:20 +0000 Reviewed-on: https://review.openstack.org/613205 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-23Merge "Remove the "emit-ara-html" role"Zuul
2018-10-21Fix build-openstack-releasenotes by non-existing msgmergeAkihiro Motoki
"gettext" command is provided by gettext-base package in Xenial. To make build-openstack-releasenotes work we need to check commands like "msgmerge" provided by gettext package. Change-Id: I6c9f303dd5f284d7df68a4b764b84a05309f6693 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sun, 21 Oct 2018 15:08:59 +0000 Reviewed-on: https://review.openstack.org/612149 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-19Merge "Update ANSIBLE_LIBRARY to use envsitepackagesdir"Zuul
2018-10-19Merge "ensure-sphinx: do not attempt a gettext install if exists"Zuul
2018-10-18Update ANSIBLE_LIBRARY to use envsitepackagesdirMonty Taylor
We install zuul via test-requirements, so the zuul files should be in a directory under the site-packges of the virtualenv that tox installed it in to. Update the path to point correctly to that location. Remove the ansible-lint skip tags which should now work because the library path should be pointing to a location that actually holds the content. Change-Id: If2d4b39267c4b9a3102a951143b568f8447af8d9 Notes (review): Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 19 Oct 2018 18:45:48 +0000 Reviewed-on: https://review.openstack.org/611622 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-18Merge "Revert "Extract pep8 messages for inline comments""Zuul
2018-10-18Revert "Extract pep8 messages for inline comments"Tobias Henkel
There seems to be a problem with openstack-zuul-jobs [1]. This reverts commit 421f533b6171ea6140e0967a75765cb73404241f. [1] http://logs.openstack.org/86/610386/3/gate/openstack-zuul-jobs-linters/a8c857d/job-output.txt.gz#_2018-10-18_07_14_42_431592 Change-Id: Iac5236221e33df4613cc2f7a2edcffc323902320 Notes (review): Code-Review+2: David Shrewsbury <shrewsbury.dave@gmail.com> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 18 Oct 2018 13:31:13 +0000 Reviewed-on: https://review.openstack.org/611549 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
2018-10-18Merge "Fix RST formatting"Zuul
2018-10-18Merge "Limit ensure-python to Debian/Ubuntu use"Zuul
2018-10-18Merge "Extract pep8 messages for inline comments"Zuul