Commit Graph

12 Commits

Author SHA1 Message Date
Ian Wienand 4340c8d473
promote-docker-image: improve failure debugability
Currently this no_logs the entire selection and delete loop, which is
probably maximal efficiency but makes it very hard to debug on failure
(which we are seeing).  This extracts the list creation and uri call
so we can see the tags it is trying to delete.

Change-Id: I93fd19aedaa9fc328a1a347986a5f0c20439d476
2023-02-08 08:26:07 +11:00
Ian Wienand 1c85809ab1
promote-docker-image: double-quote regexes
Change Ibc84e4f3fb18331ff6e2eb01037254be65dc53f5 removed the {{ from
this, which Ansible does warn about.  However it then started failing.

Upon local testing, I could see

 The conditional check 'ansible_date_time.iso8601 |
 regex_replace('^(....-..-..)T(..:..:..).*Z', '\\1 \\2') |
 to_datetime' failed. The error was: time data '\\x01 \\x02' does not
 match format '%Y-%m-%d %H:%M:%S

So for whatever reason, without the surrounding {{ }} the
regex_replace is getting turned into the string "\\1 \\2" -- not the
first and second results of the match.  Double quoting seems to fix
this.

Change-Id: I689385a3eb8b9ce373ff579c72cd29e46ebcaf8b
2023-02-08 07:27:47 +11:00
Clark Boylan 613e318a98 Fix ansible-lint no-jinja-when occurence
Ansible lint 6.12.1 released a few hours ago and started enforcing this
rule.

Change-Id: Ibc84e4f3fb18331ff6e2eb01037254be65dc53f5
2023-02-03 13:04:10 -08:00
Andrii Ostapenko a8084e54ef
Fix promote cleanup
Change-Id: I1b639e5ed221301219f808a53dcb938cccefa019
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>
2020-09-28 16:58:19 -05:00
Andrii Ostapenko ef47a743b6
Add ability to use *-docker-image roles in periodic jobs
Use '{{ zuul.pipeline }}' tag prefix in *-docker-image instead of
'change_{{ zuul.change }}' one when zuul.change is not provided, that is
the case with periodic jobs. This allows to build, upload and promote images
using periodic jobs e.g:

- project:
    periodic:
      - project-buildset-registry

      - project-build-image1:
          dependencies:
            - name: project-buildset-registry
      - project-build-image2:
          dependencies:
            - name: project-buildset-registry

      # pulls from buildset registry and tests both images
      - project-test:
          dependencies:
            - name: project-build-image1
            - name: project-build-image2

      # pre-pulls images from buildset registry for fast build
      - project-upload-image1:
          dependencies:
            - name: project-test
      - project-upload-image2:
          dependencies:
            - name: project-test

      - project-promote:
          dependencies:
            - name: project-upload-image1
            - name: project-upload-image2

This fuctionality will allow to keep latest images up to date for the
case when image incorporates continuously updating code from multiple
repositories.

Using true ternary for tag evaluation because ternary filter requires
all passed to it variables be defined or defaulted [0].

[0] https://github.com/ansible/ansible/issues/51276

Change-Id: I8eb7d2baa24905e7aac51fce0b2f9b1f24f037f9
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>
2020-09-25 14:22:17 -05:00
James E. Blair 2dc89d8347 Reinstate docker tag cleanup
This uses a new method of calculating the cutoff time which does not
require executing code on the executor.

Change-Id: I92e71727e24281a31cb7caf0b78dd17a5aaae129
Co-Authored-By: Clark Boylan <clark.boylan@gmail.com>
2020-07-22 08:39:54 -07:00
James E. Blair abd4ab18a3 Temporarily disable tag cleanup in docker promote
This was relying on a bug in the executor.  It's not critical
functionality, so just avoid it for now.

Change-Id: I6069150324d0b921cdb8cbc6902e74ec2a6036cc
2020-07-22 07:26:05 -07:00
Sorin Sbarnea 33461bbecc Enable yamllint
Adds yamllint to the linters with a minimal configuration, some
rules are disabled to allow us to fix them in follow-ups, if
we agree on them.

Fixes invalid YAML file containing characters inside block.

Fixes few minor linting issues.

Change-Id: I936fe2c997597972d884c5fc62655d28e8aaf8c5
2020-05-04 17:47:11 +01:00
Mohammed Naser 5b37cabf41 Fix incorrect variable name for promote-docker-image
The variable was changed inside the role from image to zj_image but the
included task file did not use the new variable name.  This patch fixes
this.

Change-Id: Ibe3acbd0881da24ec9c2f636d777885a309bdf98
2020-04-29 20:04:09 -04:00
Albin Vass d0e2016592 Add loop var policy to ansible-lint
This adds a custom ansible-lint rule at .rules/ZuulJobsNamespaceLoopVar.py
that enforces the loop var policy described at:
https://zuul-ci.org/docs/zuul-jobs/policy.html#ansible-loops-in-roles

It also updates existing roles to follow the policy.

Change-Id: I92b2ff56a1c2702542fc07b316f1809087a4c92f
2020-04-29 17:20:59 +02:00
Jean-Philippe Evrard 9bc813daa7 Dockerhub now returns 200 for DELETEs
We need to adapt to this, else the promote pipeline fails.

Change-Id: Ie617efc8b9a7fefb565c67c796d42c87a1ee998f
2019-06-20 10:20:40 +00:00
James E. Blair 8640466183 Add docker image promotion roles
This adds three roles which can be used to build a docker image
promotion system.

Change-Id: Iefd9278cdb90bbbaab93a4d23c055e9289fde5ba
2019-01-15 14:03:00 -08:00