Commit Graph

6 Commits

Author SHA1 Message Date
James E. Blair 5603eb2291 Revert "Refactor fetch-sphinx-tarball to be executor safe"
This reverts commit 51a8ed8e95.

This has a typo ("exector").  The fix is obvious, but the bigger
issue is that it was not caught in testing, even though the main
purpose of the change was to re-enable tests.  We should understand
why it wasn't caught in testing and resolve that before fixing and
unreverting.

Change-Id: I3ed407546fecc52d4a039f7959c0521511e6a00b
2020-10-14 13:54:22 -07:00
Ian Wienand 51a8ed8e95 Refactor fetch-sphinx-tarball to be executor safe
This reverts commit 69a238df46.

The role is re-written with executor-safe methods.

Depends-On: https://review.opendev.org/753222
Change-Id: I0b52eff66bfdca776e0e5c426bf1fc57deb3fc49
2020-10-05 15:14:31 +11:00
Albin Vass d0e2016592 Add loop var policy to ansible-lint
This adds a custom ansible-lint rule at .rules/ZuulJobsNamespaceLoopVar.py
that enforces the loop var policy described at:
https://zuul-ci.org/docs/zuul-jobs/policy.html#ansible-loops-in-roles

It also updates existing roles to follow the policy.

Change-Id: I92b2ff56a1c2702542fc07b316f1809087a4c92f
2020-04-29 17:20:59 +02:00
Monty Taylor 3b9e295a37
Use find instead of ls for determining dir emptiness
ls foo/* isn't a great way to do this - but find, as is usually
the case, solves all problems.

Change-Id: Ic30b36ccee41e9b74e187eb3cdab0359f659a1c9
2019-01-21 17:24:51 +00:00
Monty Taylor f711df6978
Fix concurrency and syntax issue in merge-output-to-logs
In a multi-node job, these mv commands run in parallel which makes
the second invocation weird and racy (even though there is a mv -f
there) Put in run_once - we don't need to perform this more than
one time, no matter how many nodes there are in the nodeset.

Also, when there are actually files present, if ! $(ls work_dir/*)
winds up expanding as a command to be run.

Change-Id: Ia59c604d6639fab762fae5e53790da8992437587
2019-01-21 14:17:44 +00:00
Monty Taylor a441d749b8
Add role to move docs and artifacts to log root
When we're operating in the context of a change, we'd like to
upload artifacts and docs to the log server so that people can iterate
on them before publication safely. Add a role which is intended to be
run after fetch-output that moves the content on the executor so that
normal log upload concepts can be applied.

Change-Id: I1791d1283a0c1f112958db8861526145abe1357c
2019-01-10 22:48:30 +00:00