This is no longer present in Ansible 9.
Removing these upsets ansible-lint, so those errors are ignored.
The base roles job has bitrotted on centos-7 and bionic due to
a bad voluptuous release used in an stestr test. That is fixed in
this change as well.
Change-Id: I67886d5ad82ab590979f82bd102d6f974b9d4421
Newer ansbile-lint finds "when" or "become" statements that are at the
end of blocks. Ordering these before the block seems like a very
logical thing to do, as we read from top-to-bottom so it's good to see
if the block will execute or not.
This is a no-op, and just moves the places the newer linter found.
Change-Id: If4d1dc4343ea2575c64510e1829c3fe02d6c273f
This is preparation for a later version of ansbile-lint, which finds
missing names on blocks. This seems a reasonable rule, and the
Ansible manual says [1]
Names for blocks have been available since Ansible 2.3. We recommend
using names in all tasks, within blocks or elsewhere, for better
visibility into the tasks being executed when you run the playbook.
This simply adds a name tag for blocks that are missing it. This
should have no operational change, but allows us to update the linter
in a follow-on change.
[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html
Change-Id: I92ed4616775650aced352bc9088a07e919f1a25f
This change enables using fetch-sphinx-tarball role along with
the fetch-output role. By default the role still synchronizes
artifacts back to the executor.
Change-Id: I7452f34bccdca49e256053f9630f77953b27f99c
We discovered that role fails on some platform because of the missing
bzip2 package. We can avoid this by using gzip which is much more
likely to exist on machines (and exists in the container images for
most operating systems).
Change-Id: Ia33a0f77343df809cd3c591a4a988e8e3712c133
Co-Authored-By: Mohammed Naser <mnaser@vexxhost.com>
Since we cannot create users this causes an error if the user is not
the same on both the host that produced the files and the executor.
Change-Id: I74464033001666c82ccfa702799e9236029df816
Since ansible copies files as a tempfile to the remote host by default
setting remote_src: true when the files are on the same host gives better
error messages since otherwise the source path is not reflecting the real path.
See: http://paste.openstack.org/show/792400/
Where the file in "dest:" field of unarchive is copied to a tempfile
instead of just unarchiving the tarball directly.
Change-Id: Id7478a5a3171fdd2d3bc7531e66a09414e711d3a
The sphinx .doctrees directory is not needed for publishing. By default
sphinx puts it below html. Some projects add to sphinx-build a "-d"
option to put the content elsewhere and not publish it.
This change assures that a .doctrees directory below "html" will not put
stored as artifact and published later.
Statistics: In all of OpenDev, we have:
* 511 repos putting .doctrees elsewhere and thus not publishing it
* 631 repos no caring and thus publishing .doctrees
The size of .doctrees directory is not neglectable: 2MB for
system-config, 14 MB for nova.
Change-Id: I63b581164aab84352d9e80278cf4a8d634ff28af
This is a new artifact-aware method of fetching sphinx tarballs,
meant to be used in docs promote jobs.
Change-Id: I9a01af9e36b959c4fa42f3c41b548c87bf2e1759
James E. Blair