summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Urdin <tobias.urdin@binero.se>2019-01-21 22:14:35 +0100
committerTobias Urdin <tobias.urdin@binero.se>2019-01-21 22:14:35 +0100
commitdb1629dc97020330df75261a8bbe04f423b25a71 (patch)
treec1bfd2c6e8d29f38d36b3f9500593fe41212c4ca
parentcb54c59577f69687b283b2ccd117fe4c0bce2f9b (diff)
Use become for packages in upload-puppetforge
The upload-puppetforge role when executed as a unprivileged user fails to install system packages and the gems in the system gem home, see failure [1]. This adds become to the calls so that it becomes the privileged user and executes these which will make them have system access like the bindep role [2]. [1] http://logs.openstack.org/61/617ffad84b633618490ca1023f8a31d9694b31a9/release/release-openstack-puppet/c6e519d/job-output.txt.gz#_2019-01-21_20_53_17_207155 [2] https://git.openstack.org/cgit/openstack-infra/zuul-jobs/tree/roles/bindep/tasks/packages.yaml#n6 Change-Id: I4f11319727a4a5694f11abad4ded69ee554326f2
Notes
Notes (review): Code-Review+2: Jeremy Stanley <fungi@yuggoth.org> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+1: Jean-Philippe Evrard <jean-philippe@evrard.me> Code-Review+1: Sean McGinnis <sean.mcginnis@gmail.com> Code-Review+2: Andreas Jaeger <jaegerandi@gmail.com> Workflow+1: Andreas Jaeger <jaegerandi@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 22 Jan 2019 20:08:54 +0000 Reviewed-on: https://review.openstack.org/632163 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
-rw-r--r--roles/upload-puppetforge/tasks/main.yaml3
1 files changed, 3 insertions, 0 deletions
diff --git a/roles/upload-puppetforge/tasks/main.yaml b/roles/upload-puppetforge/tasks/main.yaml
index d8e7fc7..3003ce2 100644
--- a/roles/upload-puppetforge/tasks/main.yaml
+++ b/roles/upload-puppetforge/tasks/main.yaml
@@ -5,6 +5,7 @@
5 - gcc-c++ 5 - gcc-c++
6 - make 6 - make
7 state: present 7 state: present
8 become: yes
8 when: ansible_os_family == "RedHat" or ansible_os_family == "Suse" 9 when: ansible_os_family == "RedHat" or ansible_os_family == "Suse"
9 10
10- name: Install ruby dependencies on Debian based 11- name: Install ruby dependencies on Debian based
@@ -14,6 +15,7 @@
14 - g++ 15 - g++
15 - make 16 - make
16 state: present 17 state: present
18 become: yes
17 when: ansible_os_family == "Debian" 19 when: ansible_os_family == "Debian"
18 20
19- name: Install required gems 21- name: Install required gems
@@ -24,6 +26,7 @@
24 - rake 26 - rake
25 - puppetlabs_spec_helper 27 - puppetlabs_spec_helper
26 - puppet-blacksmith 28 - puppet-blacksmith
29 become: yes
27 30
28# NOTE(tobias.urdin): The build task is needed because puppet-blacksmith 31# NOTE(tobias.urdin): The build task is needed because puppet-blacksmith
29# doesn't provide a build task so it fails, we don't need one anyway since 32# doesn't provide a build task so it fails, we don't need one anyway since