summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Jaeger <aj@suse.com>2018-10-25 08:09:28 +0200
committerAndreas Jaeger <aj@suse.com>2018-10-25 08:09:28 +0200
commit93ddc0247d02c118c60abe0166cd5a338c28d956 (patch)
tree23297e003838aa15c4083b21df811e5309164026
parent08af5f0110672a14917adb8fd1389fc37f433ab7 (diff)
Fix flake8 3.6.0 errors
Flake8 3.6.0 now warns about both line break after and *before* binary operator, you have to choose whether you use W503 or W504. Disable the newer W504. Also, ignore warning about invalid escape sequence in regex. Change-Id: Ibfbd5df21e01d5a7bd44a216ff63bc805dd5c186
Notes
Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 25 Oct 2018 07:37:20 +0000 Reviewed-on: https://review.openstack.org/613205 Project: openstack-infra/zuul-jobs Branch: refs/heads/master
-rw-r--r--roles/add-build-sshkey/library/test_sshagent_remove_keys.py2
-rw-r--r--tox.ini4
2 files changed, 4 insertions, 2 deletions
diff --git a/roles/add-build-sshkey/library/test_sshagent_remove_keys.py b/roles/add-build-sshkey/library/test_sshagent_remove_keys.py
index 70fa558..b13dbbd 100644
--- a/roles/add-build-sshkey/library/test_sshagent_remove_keys.py
+++ b/roles/add-build-sshkey/library/test_sshagent_remove_keys.py
@@ -78,7 +78,7 @@ class TestAgent(testtools.TestCase):
78 l = a.list() 78 l = a.list()
79 self.assertEqual(2, len(l)) 79 self.assertEqual(2, len(l))
80 80
81 run('^(?!\(stdin\)).*') 81 run('^(?!\(stdin\)).*') # noqa
82 82
83 l = a.list() 83 l = a.list()
84 self.assertEqual(1, len(l)) 84 self.assertEqual(1, len(l))
diff --git a/tox.ini b/tox.ini
index 37099aa..4ac6fc5 100644
--- a/tox.ini
+++ b/tox.ini
@@ -53,6 +53,8 @@ commands = {posargs}
53# These are ignored intentionally in openstack-infra projects; 53# These are ignored intentionally in openstack-infra projects;
54# please don't submit patches that solely correct them or enable them. 54# please don't submit patches that solely correct them or enable them.
55# E402 - ansible modules put documentation before imports. Align to ansible. 55# E402 - ansible modules put documentation before imports. Align to ansible.
56ignore = E125,E129,E402,E741,H 56# W504 - line break after binary operator, we cannot have both
57# W503 and W504 enabled
58ignore = E125,E129,E402,E741,W504,H
57show-source = True 59show-source = True
58exclude = .venv,.tox,dist,doc,build,*.egg 60exclude = .venv,.tox,dist,doc,build,*.egg