summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
39 hoursAdd support for yappi and objgraph outputHEADmasterDavid Shrewsbury
This duplicates the logic in zuul, and makes us consistent with current nodepool documentation that says we already support this. Change-Id: Ib92272b302a5225726a830ee50571fb7ad96e457 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Clint 'SpamapS' Byrum <clint@fewbar.com> Workflow+1: Clint 'SpamapS' Byrum <clint@fewbar.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 18 Apr 2019 00:18:31 +0000 Reviewed-on: https://review.openstack.org/653541 Project: openstack-infra/nodepool Branch: refs/heads/master
3 daysMerge "Gather host keys for connection-type network_cli"Zuul
3 daysMerge "Fix for orphaned DELETED nodes"Zuul
4 daysMerge "Implement max-servers for AWS driver"Zuul
4 daysGather host keys for connection-type network_cliPaul Belanger
The network_cli conneciton in ansible, is built a top of paramiko, which then uses SSH at the transport. This means hosts using this connection should also have their host keys collected. Change-Id: I0383227374bdc1a9b0cecc255eabcb8a8d097b09 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 16 Apr 2019 12:58:41 +0000 Reviewed-on: https://review.openstack.org/652778 Project: openstack-infra/nodepool Branch: refs/heads/master
4 daysFix for orphaned DELETED nodesDavid Shrewsbury
Include DELETED in the list of node states to cleanup. If we lose the ZooKeeper connection while deleting a node (after setting its state to DELETED and before actually deleting the znode), we can leave the node orphaned in the DELETED state and it never gets removed. Change-Id: Ie6c00e1adcbdf5b6f2122fc638ee5e91aaca9f61 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 16 Apr 2019 04:35:46 +0000 Reviewed-on: https://review.openstack.org/652729 Project: openstack-infra/nodepool Branch: refs/heads/master
6 daysMerge "k8s: Fix delete_namespace to use kwargs properly"Zuul
7 daysImplement max-servers for AWS driverClint Byrum
Max-servers has been ignored up until now. This implements the basic checks so that AWS users can limit the number of instances they launch. Change-Id: I73296bde1cdde80c52b6b5b725f268a17562060d Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 15 Apr 2019 21:17:33 +0000 Reviewed-on: https://review.openstack.org/649474 Project: openstack-infra/nodepool Branch: refs/heads/master
10 daysFix race with test_provider_removal unit testDavid Shrewsbury
The artificial sleep() call was sometimes not long enough for the test to succeed. Switch to using iterate_timeout(). Change-Id: I7ebdabe1a6e8ba3a01593c7b63aa784a23aca2d3 Notes (review): Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 10 Apr 2019 18:42:17 +0000 Reviewed-on: https://review.openstack.org/651339 Project: openstack-infra/nodepool Branch: refs/heads/master
11 daysMerge "Fix race in test_handler_poll_session_expired"Zuul
14 daysMerge "Remove reference to TaskManagerStopped exception"Zuul
14 daysMerge "Remove unused use_taskmanager flag"Zuul
14 daysFix race in test_handler_poll_session_expiredDavid Shrewsbury
It's possible that we could test the internal request_handlers data structure after the exception, but BEFORE it has been modified. Just wait for it to go to zero length. Change-Id: I364b1f347553a3f6710a516461c4f097d0276794 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 08 Apr 2019 17:21:36 +0000 Reviewed-on: https://review.openstack.org/650385 Project: openstack-infra/nodepool Branch: refs/heads/master
14 daysMerge "Use the buildset registry in zuul-quick-start"Zuul
2019-04-04Merge "Fix debug log message"Zuul
2019-04-04Merge "doc: add provider driver development instructions"Zuul
2019-04-04Merge "Update dib stats"Zuul
2019-04-04Fix debug log messageDavid Shrewsbury
The parameter was missing. Change-Id: If4de197e54f152ef791748783b22e19cbbd98186 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: James E. Blair <corvus@inaugust.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 19:29:40 +0000 Reviewed-on: https://review.openstack.org/650088 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-04Merge "Remove TaskManager and just use keystoneauth"Zuul
2019-04-03Merge "Pin openstacsksdk to <0.27.0"Zuul
2019-04-03Merge "Fix for image build leaks"Zuul
2019-04-03Merge "Make local dib file cleanup method a static method"Zuul
2019-04-03Merge "Use opendev docker jobs"Zuul
2019-04-02Use the buildset registry in zuul-quick-startJames E. Blair
The job no longer needs to build duplicate copies of the images, it can fetch them from the buildset registry instead. Change-Id: Ib7d2029595bf719d0411967870194fc3cc89d734 Depends-On: https://review.openstack.org/649467 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 05 Apr 2019 15:40:53 +0000 Reviewed-on: https://review.openstack.org/649468 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-02Use opendev docker jobsJames E. Blair
These utilize an intermediate registry and therefore honor dependencies. Change-Id: I9e713437e1d3541ff3c25f5178084738deac1354 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 07:03:46 +0000 Reviewed-on: https://review.openstack.org/649465 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-02Remove reference to TaskManagerStopped exceptionMonty Taylor
The TaskManagerStopped exception will never be thrown anymore by openstacksdk, since there is no TaskManager to be stopped. Stop accounting for it in the code. Change-Id: Idbdffa9ce945e41044c8eaf01cc582fca2114e6e Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 05 Apr 2019 20:02:49 +0000 Reviewed-on: https://review.openstack.org/649294 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-02Remove unused use_taskmanager flagMonty Taylor
Now that there is no more TaskManager class, nor anything using one, the use_taskmanager flag is vestigal. Clean it up so that we don't have to pass it around to things anymore. Change-Id: I7c1f766f948ad965ee5f07321743fbaebb54288a Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 05 Apr 2019 19:58:37 +0000 Reviewed-on: https://review.openstack.org/649293 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-02Remove TaskManager and just use keystoneauthMonty Taylor
Support for concurrency and rate limiting has been added to keystoneauth, which is the library openstacksdk uses to talk to OpenStack. Instead of managing concurrency in nodepool using the TaskManager and pool of worker threads, let keystoneauth take over. This also means we no longer have a hook into the request process, so we defer statsd reporting to the openstacksdk layer as well. Change-Id: If21a10c56f43a121d30aa802f2c89d31df97f121 Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 17:03:12 +0000 Reviewed-on: https://review.openstack.org/640643 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-02Pin openstacsksdk to <0.27.0Monty Taylor
The next patch removes the use of TaskManager from nodepool. This patch is mostly to cover any momentary weirdness. Change-Id: I95df226792b716ba0f60e70eb9e4072e097c85af Notes (review): Code-Review+2: James E. Blair <corvus@inaugust.com> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 17:29:32 +0000 Reviewed-on: https://review.openstack.org/649254 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-01Fix for image build leaksDavid Shrewsbury
If, during a long DIB image build, we lose the ZooKeeper session, it's likely that the CleanupWorker thread could have run and removed the ZK record for the build (its state would be BUILDING and unlocked, indicating something went wrong). In that scenario, when the DIB process finishes (possibly writing out DIB files), it will never get cleaned up since the ZK record would now be gone. If we fail to update the ZK record at the end of the build, just delete the leaked DIB files immediately after the build. Change-Id: I5cb58318efe51b5b0c3413b7a01f02a50215a8b6 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 16:12:31 +0000 Reviewed-on: https://review.openstack.org/647599 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-04-01Make local dib file cleanup method a static methodDavid Shrewsbury
By making this a static method, we can allow code other than the CleanupWorker thread to call it for DIB file removal. This change helped to identify that the builder unit test test_cleanup_failed_image_build was not valid because the fake dib creation process was exiting before creating any files. Since the test was attempting to validate those files were supposed to be deleted, it would always succeed. Moving the exit to after file creation fixes that. Change-Id: Iaa5f02abbaebd9866b6cc16c977e0d42d804eee1 Notes (review): Code-Review+2: Monty Taylor <mordred@inaugust.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 14:35:34 +0000 Reviewed-on: https://review.openstack.org/649166 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-28Use yaml.safe_load instead of loadDavid Shrewsbury
Change Ie14935f604f23b0928eed0dd8e28dff49699a2d1 altered one use of this method, but this one was missed. Change-Id: I299a12d73a6524f5097712f97342aed640786eea Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 03 Apr 2019 00:38:26 +0000 Reviewed-on: https://review.openstack.org/648436 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-21Update docs for provider removal.David Shrewsbury
The docs for provider removal were a tad inaccurate and/or misleading. This hopefully clarifies the procedure. Change-Id: I8d4d88c45dc3cea3465e5bf508d83fd940e5fdec Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Jens Harbott (frickler) <j.harbott@x-ion.de> Workflow+1: Jens Harbott (frickler) <j.harbott@x-ion.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 22 Mar 2019 09:27:50 +0000 Reviewed-on: https://review.openstack.org/645220 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-18config: use yaml.safe_load instead of loadTristan Cacqueray
This change replaces an insecure yaml.load procedure by yaml.safe_load. Change-Id: Ie14935f604f23b0928eed0dd8e28dff49699a2d1 Notes (review): Code-Review+2: Paul Belanger <pabelanger@redhat.com> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 18 Mar 2019 21:35:07 +0000 Reviewed-on: https://review.openstack.org/643849 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-15Run tox-py35 jobs on xenialTristan Cacqueray
The tox-py35 job now uses bionic nodes as default which doesn't include python 3.5. Pin the nodeset to xenial to fix this for nodepool. While at it the nodeset of the py36 jobs now can be dropped because it's already the default. Change-Id: Ie05225e791b3263f1130f5c63d9c4c31f484d70a Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 15 Mar 2019 20:01:28 +0000 Reviewed-on: https://review.openstack.org/643530 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-13k8s: Fix delete_namespace to use kwargs properlyClint Byrum
In v9.0.0 (pre-release as of this writing), the kubernetes driver only accepts the delete body as a kwarg, thus we need to pass it as one. Change-Id: Ice0262da7533077268c5d72284762760c4b083e5 Notes (review): Code-Review+1: Tristan Cacqueray <tdecacqu@redhat.com> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 13 Apr 2019 08:13:13 +0000 Reviewed-on: https://review.openstack.org/642964 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-08Remove prelude from AWS release note3.5.0James E. Blair
Change-Id: I62e4ffdbc1e0808d7cd2186d9ed55065fbee7644 Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Paul Belanger <pabelanger@redhat.com> Workflow+1: Paul Belanger <pabelanger@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 08 Mar 2019 21:25:31 +0000 Reviewed-on: https://review.openstack.org/642148 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-03-08Merge "docker: don't daemonize when starting images"Zuul
2019-02-27doc: add provider driver development instructionsTristan Cacqueray
Change-Id: I31642883f2bfb99e30820ddf72be3feedb66943e Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 18:47:10 +0000 Reviewed-on: https://review.openstack.org/639595 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-26Support requests for specific providersJames E. Blair
In Zuul we support a paradigm where a job can be paused, whereupon dependent jobs then request nodes and are started. It is nearly always the case that the user would like the nodes for the dependent jobs to be in the same provider as the parent, as the use cases generally involve transferring data between the two. To support this, add a 'provider' attribute to the node request which, if present, means that all on-line launchers for that provider must decline the request before anyone else processes it. This will cuase the desired behavior if everything is working, and if some calamity befalls that launcher, other launchers can still attempt to fulfill the request, which might work, or might not, but performing that last ditch effort is fine once there are no alternatives. Change-Id: I91fe05081695d454651f6068eac5c08ac30ff899 Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Monty Taylor <mordred@inaugust.com> Workflow+1: Monty Taylor <mordred@inaugust.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 28 Feb 2019 11:02:28 +0000 Reviewed-on: https://review.openstack.org/639418 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-22Merge "Use a pipeline for dib stats"Zuul
2019-02-22Merge "doc bugfix for static provider"Zuul
2019-02-22doc bugfix for static providerjabielecki
Insert `nodes` level for driver `static`; it was missing. Now it's `pools.[static].nodes.labels` etc. The previous `pools.[static].labels` was failing a config. Indent all the node's attributes. Move `username` and `host-key` for readability. Change-Id: Ia61fd73884f77f1d96f36038c1cd74eb37016f5c Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 22 Feb 2019 21:02:25 +0000 Reviewed-on: https://review.openstack.org/637518 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-22Update dib statsIan Wienand
This updates dib stats after creating a dashboard to use them. Firstly, the individual return codes and runtime for each image type are unnecessary, because they call come from the same invocation of dib. While it is definitely useful to track the size of each output image, the overall status for a build is only a single value. This moves these duplciated values to ".status.<rc|duration>". Unfortunately, there's really no way to say "what was the time of the last non-null value" in grafana+graphite [1]. This means you can't do something useful like show a singlestat of the relative time of the last build "X hours ago" using the timer value. We can work around this by putting the timestamp of the last build in a gauge value; this monotonically increases and is easy to turn into a relative time. [1] https://github.com/grafana/grafana/issues/10550 Change-Id: Ia9518b6faecb30d45e0509bda4a9b2ab7fdc6261 Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Workflow+1: Clark Boylan <cboylan@sapwetik.org> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 04 Apr 2019 18:14:55 +0000 Reviewed-on: https://review.openstack.org/638533 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-22Use a pipeline for dib statsIan Wienand
I noticed in OpenStack production we don't seem to be getting all the stats from dib, particularly from our very remote builder. This is likely because there is some packet loss quickly blasting out small UDP packets with the stats. A pipeline bundles the stats together into the largest size packets it can (this has been a problem before; see I3f68450c7164d1cf0f1f57f9a31e5dca2f72bc43). Add some additional checks for the size stats which did not seem to be covered by existing testing. I also noticed that the documentation had an extra ".builder." in the key which isn't actually there in the stats output. Change-Id: Ib744f19385906d1e72231958d11c98f15b72d6bd Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 22 Feb 2019 21:07:54 +0000 Reviewed-on: https://review.openstack.org/638265 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-12Properly handle TaskManagerStopped exceptionPaul Belanger
When we lose a task manager, we won't be able to create an instances. Rather then continue to look until retries limit is reached, we raise an exception early. In the case of below, the retry limit is very high and results in logs being spammed with the following: 2019-02-12 16:41:15,628 ERROR nodepool.NodeLauncher-0001616109: Request 200-0000443406: Launch attempt 39047/999999999 failed for node 0001616109: Traceback (most recent call last): File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/nodepool/driver/openstack/handler.py", line 241, in launch self._launchNode() File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/nodepool/driver/openstack/handler.py", line 142, in _launchNode instance_properties=self.label.instance_properties) File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/nodepool/driver/openstack/provider.py", line 340, in createServer return self._client.create_server(wait=False, **create_args) File "<decorator-gen-32>", line 2, in create_server File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/openstack/cloud/_utils.py", line 377, in func_wrapper return func(*args, **kwargs) File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/openstack/cloud/openstackcloud.py", line 7020, in create_server self.compute.post(endpoint, json=server_json)) File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/keystoneauth1/adapter.py", line 357, in post return self.request(url, 'POST', **kwargs) File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/openstack/_adapter.py", line 154, in request **kwargs) File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/openstack/task_manager.py", line 219, in submit_function return self.submit_task(task) File "/opt/rh/rh-python35/root/usr/lib/python3.5/site-packages/openstack/task_manager.py", line 185, in submit_task name=self.name)) openstack.exceptions.TaskManagerStopped: TaskManager rdo-cloud-tripleo is no longer running Change-Id: I5f907d19ec1e637defe90eb944f4e5bd759e8a74 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Notes (review): Code-Review+2: Clark Boylan <cboylan@sapwetik.org> Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+1: Fabien Boucher <fboucher@redhat.com> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 19 Feb 2019 15:26:03 +0000 Reviewed-on: https://review.openstack.org/636393 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-11Merge "Rename aws flavor-name to instance-type"Zuul
2019-02-08docker: don't daemonize when starting imagesMohammed Naser
This patch makes the nodepool process avoid starting up as a daemon in the Docker images, as it's not meant to become a background process within a container. In order to have consistent logging like in the daemonized mode we need to add a new foreground option that runs in foreground but without debug logging. Change-Id: I77e9e6e4f94cf726336419a2b22916cc1e974e62 Co-Authored-By: Tobias Henkel <tobias.henkel@bmw.de> Notes (review): Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Code-Review+2: James E. Blair <corvus@inaugust.com> Workflow+1: Tobias Henkel <tobias.henkel@bmw.de> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 08 Mar 2019 18:37:16 +0000 Reviewed-on: https://review.openstack.org/635584 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-08bindep: add sudoMohammed Naser
sudo is needed by diskimage-builder so it would be good to add it so that the Docker image has that included by default. Change-Id: Ic23fa24fb343fb2b93d6055de1d4c27879b5dcac Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: Ian Wienand <iwienand@redhat.com> Workflow+1: Ian Wienand <iwienand@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 11 Feb 2019 03:54:42 +0000 Reviewed-on: https://review.openstack.org/635876 Project: openstack-infra/nodepool Branch: refs/heads/master
2019-02-06Rename aws flavor-name to instance-typeMonty Taylor
The AWS term is instance-type, not flavor-name. Rename this while we don't have a huge userbase. While we're in there, rename a variable from image_name to image_id since we use image_id everywhere else. Change-Id: I1f7f16d2873982626d2434cf5ca1f6280adf739c Notes (review): Code-Review+2: Tobias Henkel <tobias.henkel@bmw.de> Code-Review+2: David Shrewsbury <dshrewsb@redhat.com> Workflow+1: David Shrewsbury <dshrewsb@redhat.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 11 Feb 2019 18:28:48 +0000 Reviewed-on: https://review.openstack.org/635153 Project: openstack-infra/nodepool Branch: refs/heads/master