zuul
/
nodepool
Code Issues Proposed changes

Fix leak detection in unmanaged quota calculation 

The negation in the unmanaged quota calculation is wrong. This leads
to the fact that nodepool things all of its nodes are leaked.

Change-Id: I60b48a80dc597afa2ceb0a3faddd4c73ffa48c6f
This commit is contained in:
Tobias Henkel 2018-11-30 21:49:07 +01:00
parent c2d410d9fe
commit f8d20d603c
No known key found for this signature in database
GPG Key ID: 03750DEC158E5FA2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nodepool/driver/openstack/provider.py
View File

@ -194,7 +194,8 @@ class OpenStackProvider(Provider):
# server so it must not be accounted for unmanaged
# quota; unless it has leaked.
nodepool_node_id = meta.get('nodepool_node_id')
if not (nodepool_node_id and nodepool_node_id in node_ids):
# FIXME(tobiash): Add a test case for this
if nodepool_node_id and nodepool_node_id in node_ids:
# It has not leaked.
continue